Storybook: Eliminate scrollbar by moving what doesn't fit on the left page to the right page.#2592
Storybook: Eliminate scrollbar by moving what doesn't fit on the left page to the right page.#2592alcole2 wants to merge 5 commits into
Conversation
…n't fit on the left page onto the right.
|
Play this branch at https://play.threadbare.game/branches/endlessm/1757-storybook-no-scrollbar/. (This launches the game from the start, not directly at the change(s) in this pull request.) |
There was a problem hiding this comment.
This works very well! Have you tried this with dozens of entries? If so, how? It would be nice to have a way to mock a lot of entries for testing the book.
I left a suggestion about an unneeded variable, it's just a detail.
Please:
- Use imperative for the title of the pull request. Something like "Storybook: Eliminate scrollbar..."
- Add a description to the pull request
- In the description, add "Resolves... " as last line with a link to the resolved issue.
Check https://github.com/endlessm/threadbare/wiki/Contributing#pull-request-descriptions for the convention details of the request above!
|
@alcole2 I tested this with the Template Elder which has a single quest, and this is what I see: Grabacion.de.pantalla.desde.2026-07-24.11-15-35.mp4 |
|
Interesting, I think I know how to fix that! |
Great, I have added a test scene with mock titles: #2593 Please review it, as it will be useful for this pull request. This is how your change looks like with 30 mock titles: Grabacion.de.pantalla.desde.2026-07-24.11-38-15.mp4And with six:
|
|
I fixed it! Initially, I had moved the MarginContainer to the center of the book so everything would align properly when both sides of the book were needed, not realizing that it placed the StoryQuests in the middle of the book when there was 8 or less items. If the right page isn't needed, it wouldn't put any buttons on it and therefore it kind of didn't exist. I just changed it so that if there is 8 StoryQuests or less, it will basically fill up the right side with space so it still correctly aligns with the book. I need to fix the rest of your changes and then update the pull request. Question: Are the pages for each StoryQuest in the scene with mock titles blank simply because there isn't actually any information attached to them? |
Yes, check the script in https://github.com/endlessm/threadbare/blob/cf8d301f78122f0c01468c771879ca2919df21d5/scenes/menus/storybook/components/storybook_test.gd |
Co-authored-by: Manuel Quiñones <manuq@endlessaccess.org>
Co-authored-by: Manuel Quiñones <manuq@endlessaccess.org>
Co-authored-by: Manuel Quiñones <manuq@endlessaccess.org>

Currently, all StoryQuests are on the left page of the Storybook, using a scrollbar to see and navigate through them all. I have removed the scrollbar by having what doesn't fit in a no-scrollbar view of the left page moved to the right page. When there isn't enough space on either page, the use can flip the page and the remaining StoryQuests will be there.
Resolves #1757