Repository navigation
SSR renderer pool leaks on app restart #2325 - #2326
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2326 +/- ##
=======================================
Coverage 22.85% 22.85%
=======================================
Files 1 1
Lines 35 35
=======================================
Hits 8 8
Misses 27 27 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused configuration change directly addresses the reported retention path without affecting pool behavior.
0 open findings
What changed in this PR
Disables JMX registration for SSR renderer pools, preventing old application classloaders and Graal engines from being retained after restarts.
Changes:
- Disables JMX in the renderer pool configuration.
| File | Description |
|---|---|
ServerSideRenderer.java |
Prevents renderer pools from registering as JMX MBeans. |
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
anatol-sialitski
approved these changes
Oct 8, 2026
rymsha
added a commit
that referenced
this pull request
Oct 8, 2026
rymsha
added a commit
that referenced
this pull request
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disable JMX for the renderer pool. Fixes #2325
🤖 Generated with Claude Code