Skip to content

window.devicePixelRatio changes on zoom but is only read once on load, is this intended? #15

Description

@bessw

window.devicePixelRatio changes on zoom but is only read once on load, is this intended?

expectation

As far as I understand, it is used to maintain a high resolution even if the device independent pixels are larger then the physical ones, thus I'd expect that the scalings that are done in setSize need to be adjusted then the window.devicePixelRatio changes.

actual behavior

Only the initial zoom on page load is considered .

problems

I'm unsure what would happen to Hit.getIntersection(x,y) using webgl, when the Concrete.PIXEL_RATIO would change but Hit.setSize(w,h) hasn't been called before, but if I understand it right this function will anyways fail if Concrete.PIXEL_RATIO isn't an integer and that is only given for zoom factors multiple of 100%.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions