Repository navigation
fix(runner): support DSH 0.2.2-rc.3 on Windows - #300
Open
Minervaowl7 wants to merge 1 commit into
Open
Minervaowl7 wants to merge 1 commit into
Minervaowl7 wants to merge 1 commit into
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
Merge Protections🟠 1 of 2 protections blocking · waiting on 🤖 CI
🟠 Queue ready pull requestsWaiting for
Waiting checks:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The DSH runner rejects
0.2.2-rc.3on Windows before authentication preflight. This version works with the existing bounded runner modes in the Windows checks below.What changed
0.2.2-rc.3on Windows while keeping the existing0.2.1-rc.2support.Scope
Only the DSH version guard, its tests, and generated documentation change. The runner keeps the existing preflight and sandbox settings.
Related to #255.
Blast Radius
Windows users with DSH
0.2.2-rc.3can reach the existing preflight and model launch. The version guard still rejects unmeasured releases before preflight.Verification
unavailable-clibefore preflight. With the patch, the desktop DSH CLI completed real read-only and isolated-write turns on disposable fixtures. All 19 DSH adapter tests passed.bun run testpassed 510 tests.bun run typecheckandbun run staticpassed, including manifest validation and 219 verifier tests.The repository's formal
live-gateis pending. Relevant verifier features areclaude:runnerandcodex:runner.