Resolve Elixir 1.20 type checker warnings - #246
Merged
Merged
Conversation
Owner
|
Thank you! 💜 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two sources, no behavior change:
The non guard expansions of
is_decimal/1are a case with a %Decimal{}clause and a catch all. When the argument is statically known to be a
%Decimal{} the type checker proves the catch all unreachable and warns
at every such call site, including the doctest. Marking the quoted
expansion
generated: truedeclares the catch all deliberate,following the convention for macro generated code.
Three tests pass intentionally invalid input to assert the raise
(new/1 with an atom, to_integer/1 with a NaN coefficient, round/1 with
nil). Routing those calls through apply/3 keeps the argument opaque to
the type checker, which does not check dynamic dispatch, while
exercising exactly the same failure path.