fix: crash in no-important on non-standard important values - #541
Draft
Pixel998 wants to merge 1 commit into
Draft
fix: crash in no-important on non-standard important values#541Pixel998 wants to merge 1 commit into
no-important on non-standard important values#541Pixel998 wants to merge 1 commit into
Conversation
DMartens
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
AI acknowledgment
What did you do?
What did you expect to happen?
No error.
!ieis a non-standard hack, not an!importantflag.What actually happened?
What is the purpose of this pull request?
This PR fixes the crash above.
importantholds the raw identifier for hacks like!ie, which is truthy, so the rule went on to locate the flag in the source text, found no match, and dereferencednull.What changes did you make? (Give an overview)
Narrowed the check to
important === true, so only real!importantflags are reported.Depends on eslint/csstree#152, which makes
!IMPORTANTparse astrue.Related Issues
Is there anything you'd like reviewers to focus on?