Repository navigation
feat: gate unpause and unpauseUntil to the super guardian - #504
Open
0xpanicError wants to merge 1 commit into
Open
0xpanicError wants to merge 1 commit into
0xpanicError wants to merge 1 commit into
Conversation
Pausable.unpause() and PausableUntil.unpauseUntil() move from onlyOperatingMultisig to onlySuperGuardian. pause() stays with the operating multisig and pauseUntil() keeps its existing gating (guardian, or super guardian on eETH/weETH). No storage changes. Tests: TestSetup grants SUPER_GUARDIAN_ROLE to the addresses that already unpause (owner, alice, admin); per-suite unpauser helpers and negative unpause tests now use SUPER_GUARDIAN_ROLE / OnlySuperGuardian. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
📊 Forge Coverage ReportGenerated by workflow run #831 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pausable.unpause()andPausableUntil.unpauseUntil()move fromonlyOperatingMultisigtoonlySuperGuardian.pause()stays with the operating multisig.pauseUntil()keeps its gating (guardian, or super guardian on eETH/weETH).SUPER_GUARDIAN_ROLEcomment inRoleRegistry.Affected contracts (all inherit the base change, no overrides):
PausableUntil: EETH, WeETH, LiquidityPool, Liquifier, EtherFiRestaker, CumulativeMerkleRewardsDistributor, WithdrawRequestNFT, EtherFiRedemptionManager, PriorityWithdrawalQueue, WeETHWithdrawAdapter, AuctionManager, EtherFiNodesManagerPausableonly: EtherFiOracle, NodeOperatorManager, EtherFiRateLimiter, MembershipManager (src/archive)Storage layout
No impact. Only modifiers change.
Rollout notes
SUPER_GUARDIAN_ROLEbefore or in the same batch as the upgrades. Otherwise a single key can unpause every contract.revokeFastcan revokeSUPER_GUARDIAN_ROLE. If every holder is revoked, nothing can be unpaused until the registry owner grants the role again.PausableUntil.sol, the_grantPauseUntilRoleshelpers in EETH/WeETH/CumulativeMerkleRewardsDistributor tests). Whichever merges second needs a small rebase.Tests
TestSetupgrantsSUPER_GUARDIAN_ROLEto owner, alice and admin, the addresses tests already unpause as.SUPER_GUARDIAN_ROLE. Negative unpause tests expectOnlySuperGuardian.Ran locally:
forge build: passes.forge test --no-match-path 'test/{fork-tests,integration-tests,behaviour-tests}/**': 894 passed, 100 failed. Identical tomaster; all 100 fail on the fork RPC (HTTP 403).Not run: fork, integration, and behaviour suites (no RPC).
🤖 Generated with Claude Code
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.Note
High Risk
Reshapes emergency recovery governance across every inheriting contract; a compromised or overly broad super guardian holder can lift pauses the multisig cannot reverse without registry owner action.
Overview
Unpausing protocol contracts is moved from the 4/7 operating multisig to
SUPER_GUARDIAN_ROLE.In the shared bases
PausableandPausableUntil,unpause()andunpauseUntil()now useonlySuperGuardianinstead ofonlyOperatingMultisig. Pause paths are unchanged: indefinitepause()stays on the operating multisig, and timedpauseUntil()stays on the guardian (or stricter overrides on eETH/weETH).RoleRegistrynatspec forSUPER_GUARDIAN_ROLEis updated to mention unpausing all pausable contracts.Tests and
TestSetupgrantSUPER_GUARDIAN_ROLEto addresses that unpause in tests, and negative cases expectOnlySuperGuardian.Reviewed by Cursor Bugbot for commit 70e154b. Bugbot is set up for automated code reviews on this repo. Configure here.