Repository navigation
fix(archive): restore live TNFT and EtherFiViewer semantics - #506
Open
seongyun-ko wants to merge 1 commit into
Open
seongyun-ko wants to merge 1 commit into
seongyun-ko wants to merge 1 commit into
Conversation
📊 Forge Coverage ReportGenerated by workflow run #836 |
seongyun-ko
marked this pull request as ready for review
November 12, 2026 21:11
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The archived TNFT and EtherFiViewer source on
masterdiffers from the implementations serving Ethereum mainnet at block 26401122. This restores the live primary-source behavior to the repository. It does not upgrade any deployed contract.0x7B5ae07E2AF1C861BcC4736D23f5f66A61E0cA5e→ implementation0xafb82ce44fd8a3431a64742bcd3547eeda1afea7: restore the one-associated-validator transfer restriction, including its legacy selector.0x2ecd155405cA52a5ca0e552981fF44A8252FAb81→ implementation0x19c10a7e39d5457c4a3cb2c8909297d6020594d7: restore its live constructor shape, old pubkey API, and removed view helpers. Update constructor callers in the historical upgrade scripts and tests so the repo builds.The old dependencies no longer expose some selectors. The live TNFT manager reverts on
numAssociatedValidators(uint256)at that block, so restoring this source does not make TNFT transfers work today. A live Viewer getter also reverts. Do not use this PR as a deployment plan.Who changed TNFT, and audit evidence
audits/namessrc/TNFT.soland PR v3 prelude #256. Its initial/final commit fields contain only the literalHash. It establishes named scope, not proof that Certora reviewed this specific deletion or an exact commit. No additional report is being invented or duplicated; ask Certora for the unredacted scope hashes if commit-level coverage is required.Verification and limits
forge buildpassed; targeted TNFT and Viewer tests: 6 passed. TNFT test failed on original master and again when the restored guard was deliberately bypassed; Viewer tests failed on original master and passed after restoration, with a forced-recompile mutation caught.reaudit-fixesscript bytecode checks remain unvalidated and must not be executed from this change.deployment/deployed-contracts.jsonare stale deployment records; that separate record issue is not rewritten here. No changes to EtherFiRedemptionManager, which already matches live master source.Review focus: Is preservation of these archived, partly unavailable live APIs the intended documentation policy? A real contract upgrade or byte-identical historical rebuild needs a separate plan.
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.Note
Low Risk
Changes are confined to archive contracts, historical scripts, and tests; they do not modify production deployment paths or live upgrade execution.
Overview
Aligns archived TNFT and EtherFiViewer source with live mainnet behavior (documentation/source only; no on-chain upgrade in this PR).
TNFT again overrides
_transferso transfers only succeed whenEtherFiNodesManager.numAssociatedValidators(tokenId) == 1, using a minimalILegacyTNFTNodesManagerinterface instead of the full manager import.EtherFiViewer drops constructor-injected EigenLayer manager addresses and resolves
delegationManager/eigenPodManagervia the nodes manager. It adds legacy-style batch view helpers (restaking flags, execution-layer balance splits, unused-safe aggregation, node metadata) and makesEigenPod_validatorPubkeyHashToInfoacceptbytes[][]pubkeys and delegate tovalidatorPubkeyToInfo. Re-audit deploy/transaction scripts and tests are updated for the argumentless constructor, including new mocked “live semantics” viewer tests and a TNFT transfer guard test.Reviewed by Cursor Bugbot for commit 6cc3cbe. Configure here.