Experiment: Try to make crunch64 not mandatory - #552
Draft
AngheloAlf wants to merge 2 commits into
Draft
Conversation
WIP for issue ethteck#331
AngheloAlf
marked this pull request as draft
August 6, 2026 12:58
Owner
|
I like this approach a lot. I think the only thing I'm not in love with is specifically the name |
Collaborator
Author
|
Renamed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP for issue #331
The current state is an experiment. Looking for testing and feedback
With this branch you could avoid installing crunch64 and use everything else without much issue.
For this you would need to install
[mips-min]instead of[mips]dependency group.To test this branch, either:
pip install .[mips-min]on a fresh venv.pip uninstall splat64 -y && pip install git+https://github.com/AngheloAlf/splat.git@optional-dependencies[mips-min]on a fresh venv.A fresh venv is needed to ensure you don't have crunch64 from a previous installation.
If splat detects you want to use either
mio0oryay0then it suggest you to installsplat64[compression]to get them, since they aren't available here, I think. I haven't tried this tho, so would be nice if somebody tries it out first.splat64[compression]implies bothsplat64[compression,mips-min]The usual
splat64[mips]group still installscrunch64to avoid breaking current setups.