fix(manage_conversation_labels): log silent no-op on add - #71
Open
mateusbellozupko wants to merge 1 commit into
Open
mateusbellozupko wants to merge 1 commit into
mateusbellozupko wants to merge 1 commit into
Conversation
When every requested label is already present on the conversation, the add branch returned success with no logger call at all, unlike the success-with-new-labels path (which logs) and the exception path (which also logs). This makes it impossible to tell from application logs whether an add call actually changed anything or silently no-op'd, which matters when diagnosing why a multi-step agent turn made several add calls in a row without visible progress. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThe PR makes silent no-op Flow diagram for no-op conversation label addition loggingflowchart TD
A[manage_conversation_labels add] --> B[Read current conversation labels]
B --> C{Any new labels?}
C -->|No| D[logger.info]
D --> E[Return success: nothing to update]
C -->|Yes| F[Continue existing label update flow]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
manage_conversation_labels'saddaction returns success silently (nologgercall) when every requested label was already present on the conversation — unlike the success-with-new-labels path and the exception path, both of which log.addcall actually changed anything, which matters when diagnosing an agent turn that issues severaladdcalls in a row without visible progress in the label list.logger.infocall in that branch with the requested labels and the current label list, matching the logging style already used elsewhere in this file.Test plan
python3 -m py_compileon the modified file🤖 Generated with Claude Code
Summary by Sourcery
Bug Fixes: