Skip to content

DO NOT MERGE -- verify non-empty findings on v0.2.4 - #103

Closed
exactml wants to merge 1 commit into
masterfrom
test/verify-nonempty-findings
Closed

exactml wants to merge 1 commit into
masterfrom
test/verify-nonempty-findings

Conversation

@exactml

@exactml exactml commented Sep 20, 2026

Copy link
Copy Markdown
Owner

Throwaway verification PR, not meant to merge. Deliberately introduces an obvious bug (is_even returns True for odd numbers) so the reviewer model has to generate a real, non-empty findings payload -- the exact case every prior strict-mode failure (the $PARAMETER_NAME wrapper, the stringified array, the 400 rejection) only ever happened on. Will close this and delete the branch once verified either way.

Throwaway file with a deliberate, obvious logic bug (is_even returns
True for odd numbers) to force the reviewer model to generate a
real, non-empty findings list -- the case that broke in every prior
strict-mode failure. Will be deleted; this PR is not meant to merge.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 marginal review

PR #103: DO NOT MERGE -- verify non-empty findings on v0.2.4 · open · 2d1ad43f6114b0119ee426be3d6433ef356fbfe9 → 16da681c9b4719bac027087f1a6e82376c3691a9 · 1 file changed

Changed files (1)
  • scratch_verify_findings.py


def is_even(n: int) -> bool:
"""Return whether `n` is even."""
return n % 2 == 1

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟠 High · 98% confidence

The function is_even has an inverted/incorrect implementation: n % 2 == 1 returns True for odd numbers, not even ones. This bug would cause the function to always return the wrong result.

@@ -0,0 +1,11 @@
"""Throwaway file to force a non-empty marginal review finding.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Medium · 85% confidence

This file is explicitly marked as a throwaway/scratch file with 'DO NOT MERGE' in its docstring, indicating it should not be part of the final PR. It should be removed before merging.

@exactml

exactml commented Sep 20, 2026

Copy link
Copy Markdown
Owner Author

Verification complete -- v0.2.4 correctly generated and posted 2 real findings (98% and 85% confidence) for this deliberate bug. Closing without merging, deleting the branch.

@exactml exactml closed this Sep 20, 2026
@exactml
exactml deleted the test/verify-nonempty-findings branch September 20, 2026 12:23
@exactml exactml added the test label Sep 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant