fix(auth): preserve organization invitations through login by niemyjski · Pull Request #2528 · exceptionless/Exceptionless

niemyjski · 2026-08-25T12:20:24Z

Summary

forwards invitation tokens through password and OAuth login/signup flows
starts logout after either auth page loads when a session exists, matching the legacy client behavior without adding a page-level loader
preserves the invitation token when switching between the login and signup routes
keeps invitation OAuth authentication separate from authenticated account linking while preserving normal OAuth account linking
permits an invited OAuth user to create an account when general account creation is disabled and rejects invalid invitation tokens
adds backend endpoint and end-to-end coverage for invitation acceptance

The invitation email already links to /signup?token=... on main. The legacy login and signup flows forwarded InviteToken to OAuth providers and logged out an existing authenticated session. This PR restores that behavior in the Svelte client and closes the backend gap that allowed invitation authentication to enter the account-linking branch.

This PR does not change organization persistence, organization selection, organization switching or impersonation, organization routes, or the ExternalAuthInfo model/order. Organization state and logout persistence behavior remain identical to main.

Verification

dotnet build tests/Exceptionless.Tests/Exceptionless.Tests.csproj --disable-build-servers -m:1 (0 warnings, 0 errors)
focused AuthEndpointTests executable run (51 passed), with all new external-auth cases using GitHub
focused coverage confirms every changed executable AuthHandler line is hit and the invite-versus-linking condition has 100% branch coverage
focused OpenApiSnapshotTests executable run (4 passed)
npm run check (0 errors, 0 warnings)
targeted Prettier checks
git diff --check
hosted test-client, test-api, test-e2e, and docker-build checks passed on the prior pushed head; the latest auth-page cleanup is running the same checks now

Post-Deploy Monitoring & Validation

Verify that existing password users and new OAuth users can accept organization invitations from tokenized signup/login links, including when public account creation is disabled. Confirm the invitation is consumed, membership appears, and ordinary authenticated OAuth continues to link the current account.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3baf39f1f9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 14799e817d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 18072df35a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f8e7a4e9dd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d76b4b71b2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 47f8579c19

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 79853bd581

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b3923fee0d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-08-27T20:20:35Z

+    onMount(async () => {
+        if (accessToken.current) {
+            try {
+                await logout();


Release the auth form when logout rejects

When a user opens this page with a stored access token and the logout request rejects because the API is unavailable, times out, or returns an unexpected error, this catch leaves accessToken.current unchanged. The container therefore remains inert={!!accessToken.current}, making every login control unusable despite the comment saying the flow can continue; the signup page has the same failure mode. Clear the local session on failure or track logout progress separately from the access token.

Useful? React with 👍 / 👎.

github-actions · 2026-08-27T20:28:44Z

Package	Line Rate	Branch Rate	Complexity	Health
Exceptionless.Insulation	37%	35%	286	❌
Exceptionless.Core	76%	67%	10288	✔
Exceptionless.Web	85%	69%	7974	✔
Exceptionless.AppHost	38%	41%	147	❌
Summary	79% (25559 / 32524)	68% (11973 / 17719)	18695	✔

chatgpt-codex-connector Bot reviewed Aug 25, 2026

View reviewed changes

Comment thread src/Exceptionless.Web/ClientApp/src/routes/(auth)/login/+page.svelte

Comment thread ...xceptionless.Web/ClientApp/src/routes/(app)/organization/[organizationId]/users/+page.svelte Outdated

niemyjski mentioned this pull request Aug 25, 2026

refactor(email): render existing templates with Svelte 5 #2258

Closed

chatgpt-codex-connector Bot reviewed Aug 25, 2026

View reviewed changes

Comment thread src/Exceptionless.Web/ClientApp/src/lib/features/auth/index.svelte.ts

niemyjski force-pushed the feature/invitation-auth-flow branch from 14799e8 to 18072df Compare August 26, 2026 02:28

chatgpt-codex-connector Bot reviewed Aug 26, 2026

View reviewed changes

Comment thread src/Exceptionless.Web/ClientApp/src/routes/(auth)/login/+page.svelte

niemyjski self-assigned this Aug 27, 2026

niemyjski commented Aug 27, 2026

View reviewed changes

Comment thread src/Exceptionless.Web/ClientApp/src/lib/features/users/components/table/options.svelte.ts Outdated

niemyjski commented Aug 27, 2026

View reviewed changes

Comment thread ...eptionless.Web/ClientApp/src/routes/(app)/organization/[organizationId]/billing/+page.svelte Outdated

fix(auth): preserve organization invitations through login

f8e7a4e

niemyjski force-pushed the feature/invitation-auth-flow branch from 18072df to f8e7a4e Compare August 27, 2026 12:27

chatgpt-codex-connector Bot reviewed Aug 27, 2026

View reviewed changes

Comment thread src/Exceptionless.Web/ClientApp/src/lib/features/auth/index.svelte.ts Outdated

niemyjski added 3 commits August 27, 2026 07:41

fix(auth): preserve existing organization state behavior

b238305

Merge remote-tracking branch 'origin/main' into HEAD

c1fb450

fix(auth): clear cached account data before invite OAuth

d76b4b7

chatgpt-codex-connector Bot reviewed Aug 27, 2026

View reviewed changes

Comment thread src/Exceptionless.Web/ClientApp/src/routes/(auth)/login/+page.svelte

niemyjski added 4 commits August 27, 2026 08:07

fix(auth): clear cached account data before invite password auth

ba58f6a

test(auth): use GitHub for invitation OAuth coverage

09e9055

refactor(auth): keep invitation logout at page boundary

c15ee96

refactor(auth): use plain logout for invitation auth

47f8579

chatgpt-codex-connector Bot reviewed Aug 27, 2026

View reviewed changes

Comment thread src/Exceptionless.Web/ClientApp/src/routes/(auth)/login/+page.svelte Outdated

niemyjski added 2 commits August 27, 2026 08:43

refactor(auth): minimize invitation client changes

b905fbd

refactor(auth): logout invitation sessions on entry

79853bd

chatgpt-codex-connector Bot reviewed Aug 27, 2026

View reviewed changes

Comment thread src/Exceptionless.Web/ClientApp/src/routes/(auth)/signup/+page.svelte Outdated

niemyjski added 2 commits August 27, 2026 15:14

fix(auth): simplify invitation page logout

0879a6e

fix(auth): await auth page logout

b3923fe

chatgpt-codex-connector Bot reviewed Aug 27, 2026

View reviewed changes

ejsmith merged commit bc90aa8 into main Aug 27, 2026
12 checks passed

ejsmith deleted the feature/invitation-auth-flow branch August 27, 2026 20:33

Uh oh!

Uh oh!

Conversation

niemyjski commented Aug 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Verification

Post-Deploy Monitoring & Validation

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Aug 27, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Aug 27, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

niemyjski commented Aug 25, 2026 •

edited

Loading