Skip to content

chore(utils): remove unused ICMP formatters - #884

Open
natalie-o-perret wants to merge 1 commit into
masterfrom
fix/remove-unused-icmp
Open

chore(utils): remove unused ICMP formatters#884
natalie-o-perret wants to merge 1 commit into
masterfrom
fix/remove-unused-icmp

Conversation

@natalie-o-perret

Copy link
Copy Markdown
Contributor

Description

govulncheck ./... reports GO-2026-5970 through the unused utils/icmp package. The package has no callers, exposes no usable API outside its package, and is not linked into the CLI binary.

Remove the dead ICMP formatting package and regenerate vendored dependencies. This also reclassifies golang.org/x/text as an indirect dependency and prunes the casing implementation that was used only by the removed package.

Checklist

(For exoscale contributors)

  • Changelog updated (under Unreleased block, and add the Pull Request #number for each bit you add to the CHANGELOG.md)
  • Testing

Testing

The following commands passed locally:

go fmt ./...
make lint
go vet ./...
make build
make test-verbose
go test ./...
(cd tests/e2e && go test -v)
golangci-lint run --timeout 4m
govulncheck ./...

The API-free E2E suite passed. govulncheck ./... reported no reachable vulnerabilities. Repeating go mod tidy && go mod vendor produced no further changes.


Note

AI assistance: vulnerability analysis, PR description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant