fix: Add error handling to write_predictions_to_csv - #18
Draft
exploring-curiosity wants to merge 1 commit into
Draft
exploring-curiosity wants to merge 1 commit into
exploring-curiosity wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17
What changed
The function writes predictions to CSV without any validation or error handling. If predictions is None, empty, or malformed, it will crash or produce a broken file. Add input validation (check predictions is a non-empty list of tuples) and wrap file I/O in try/except to handle permission/disk errors gracefully.
Approach
Locate the write_predictions_to_csv function in the codebase (likely in a Python file under model_serving or data_pipeline). Add input validation to ensure predictions is a non-empty list of tuples, raising a ValueError if invalid. Wrap the CSV writing logic in a try/except block to catch and handle IOError/OSError (e.g., permission denied, disk full) with a descriptive error message.
Files: model_serving/BirdClassification/app.py
Verification
internal: diff sanityno notebooks changedno build step configuredpre-existing failure, not introduced by this changeno runtime check configuredWhy this is a draft