fix: Fix F821 in pann_features_mlp.py:455: Undefined name CosineAnnealingLR - #33
Draft
exploring-curiosity wants to merge 1 commit into
Draft
fix: Fix F821 in pann_features_mlp.py:455: Undefined name CosineAnnealingLR#33exploring-curiosity wants to merge 1 commit into
CosineAnnealingLR#33exploring-curiosity wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #22
What changed
ruffreports F821 atmodel_train/old/pann_features_mlp.py:455:Fix the cause in
model_train/old/pann_features_mlp.py. Change only what this finding requires.Approach
Add
CosineAnnealingLRto the import statement fromtorch.optim.lr_schedulerinmodel_train/old/pann_features_mlp.py.Files: model_train/old/pann_features_mlp.py
Verification
internal: diff sanityno notebooks changedno build step configuredpre-existing failure, not introduced by this changeno runtime check configuredWhy this is a draft