Skip to content

msgpack: Fix backwards compatibility for non-strict map keys - #122

Open
mgorny wants to merge 1 commit into
explosion:masterfrom
mgorny:msgpack-fix
Open

mgorny wants to merge 1 commit into
explosion:masterfrom
mgorny:msgpack-fix

Conversation

@mgorny

@mgorny mgorny commented Sep 2, 2026

Copy link
Copy Markdown

Pass strict_map_key=False to msgpack.load*(), in order to fix backwards compatibility after unvendoring msgpack. Otherwise, spaCy models fail to load.

Curious enough, msgpack permits serializing dictionaries with int keys unconditionally, but requires the switch for a working round-robin. Reported in conda-forge/srsly-feedstock#62.

Pass `strict_map_key=False` to `msgpack.load*()`, in order to fix
backwards compatibility after unvendoring `msgpack`.  Otherwise, spaCy
models fail to load.

Curious enough, `msgpack` permits serializing dictionaries with int keys
unconditionally, but requires the switch for a working round-robin.
Reported in conda-forge/srsly-feedstock#62.

Signed-off-by: Micha艂 G贸rny <mgorny@quansight.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant