Skip to content

Fix versionagedays() misparsing build time as a date #1421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vairakkumaarsvs wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix versionagedays() misparsing build time as a date #1421

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion eden/scm/sapling/util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -492,7 +492,16 @@ def versionagedays() -> int:
try:
v = version()
parts = remod.split("_", v)
approxbuilddate = datetime.datetime.strptime(parts[1], "%Y%m%d")
# The build-date segment's index varies by build path: Meta's internal
# Buck build prepends a "MAIN_VERSION" part (making it "x.y.z_YYYYMMDD_
# HHMMSS_hash", date at index 1), while the open-source build.py path
# omits that prefix ("YYYYMMDD_HHMMSS_hash", date at index 0). Scan for
# the first all-digit, 8-character part instead of assuming a fixed
# index, so this doesn't silently misparse a HHMMSS part as a date.
datepart = next((p for p in parts if len(p) == 8 and p.isdigit()), None)
if datepart is None:
return 0
approxbuilddate = datetime.datetime.strptime(datepart, "%Y%m%d")
now = datetime.datetime.now()
return (now - approxbuilddate).days
except Exception:
Expand Down