Fix get_files(directory) on S3 and local storage drivers

[tmgbedu]

Fixes #218

Problem

get_files(directory) was broken on both drivers, in two different ways, and the drivers disagreed about what the method means — making it unusable in disk-agnostic code:

1. S3 — the nested-file filter tested "/" not in key against the whole key instead of the part below the prefix. Any key matched by a non-empty Prefix necessarily contains prefix + '/', so every match was discarded and root-level keys leaked through instead. get_files("backups") always returned [].
2. Local — os.listdir yields bare names, but contents were fetched with self.get(f), which resolves against the disk root rather than root/<directory>. The lookup missed, get() swallowed the FileNotFoundError, and callers silently received File objects with None content.
3. Fake — FakeDriver extends LocalDriver, so it inherited the same broken listing (its own assert_count(n, directory) relied on it).

Fix

One converged, documented contract across all three drivers: non-recursive listing of the files directly under the given directory, bare filenames, no directory entries, [] for empty or nonexistent directories.

• S3: filter with a slash-terminated prefix (Prefix="backups/") and test only the key's relative part. This also stops get_files("backups") from matching a backups-old/ sibling and skips directory-marker keys.
• Local: read contents from join(directory, f); return [] for a nonexistent directory (matching S3's behavior for an unknown prefix).
• Fake: inherits the fixed LocalDriver.get_files; dedicated tests lock the semantics in.

Testing

• Mocked S3 unit tests for the prefix/relative-key logic (root listing, trailing slash, partial-name prefix, directory markers, nested dirs).
• Live integration tests against a real S3 API (MinIO in Docker) — bucket with keys at root, one and two levels deep; asserts every listing shape. Auto-skipped when no MinIO endpoint is reachable, endpoint/credentials overridable via MINIO_ENDPOINT / MINIO_ACCESS_KEY / MINIO_SECRET_KEY. All 8 pass against the live server.
• Local/Fake tests now assert file content equals the bytes written, not merely non-None, plus trailing-slash, empty-dir, nonexistent-dir and nested-dir cases.
• boto3 added to the dev dependency group to support the S3 tests.

Full suite: uv run pytest --ignore=tests/masoniteorm/postgres --cov → 2213 passed, 7 skipped, coverage 84.50% (threshold met).

🤖 Generated with Claude Code

https://claude.ai/code/session_01KVFQTBaxKHnCZfjmtx2HYg

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!