Add typed ORM fields and blocking basedpyright CI - #224
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Resolve conflicts in fastapi_startkit/pyproject.toml and masoniteorm/models/model.py. - pyproject.toml: keep basedpyright from this branch alongside main's pyright and pytest-benchmark dev dependencies. - model.py: union the typing imports so the dataclass_transform decorator on Model coexists with main's overload-typed where() and get(). - uv.lock regenerated with `uv sync`. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
tests/utils/test_structures.py imported `fastapi_startkit.utils.structures`, a module that does not exist, so collection aborted with ModuleNotFoundError and took the whole suite down with it. The helpers `load`, `data`, `data_get` and `data_set` live in `fastapi_startkit.support.structures`. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Support declarative ORM fields such as
id = Field[int](), inferred defaults such asField(default=False), and nested Pydantic values such asaddress = Field[Address](). Register field specifiers withdataclass_transformon the base model, derive runtime casts from explicit generic types or defaults, and include descriptor-only fields in fillable attributes.Keep
ModelFieldavailable for compatibility and emit a deprecation warning announcing removal in 2.x, withField[YourModel]()as the replacement.Replace Pyright with basedpyright in development dependencies and CI. The type-check job is blocking and has no baseline: existing type errors will currently fail CI and are deferred for subsequent work.
Validation
git diff --checkpassed.