Conversation
Doesn't have gcc13+
…'ing `ghostty +show-config` (#2122)
Note: Windows doesn't have a unix-like init system process, but it does have the first userland process, which is `smss.exe`
Dead years ago: https://github.com/magpie-linux
The redundant `if (index < strbuf->length)` check inside the static string branch is always true since `strbuf->length <= index` is already checked at the top of the function and returns false. Remove this dead code for clarity. Co-authored-by: tru3 <tru3@tru3.com>
#2476) 13 FFstrbuf fields were initialized but never destroyed, potentially leaking memory when configured via JSON or command-line: - barBorderLeft, barBorderRight - barBorderLeftElapsed, barBorderRightElapsed - barColorElapsed, barColorTotal, barColorBorder - tempColorGreen, tempColorYellow, tempColorRed - percentColorGreen, percentColorYellow, percentColorRed Co-authored-by: tru3 <tru3@tru3.com>
- Add missing ffStrbufDestroy(&options->outputColor) in ffDestroySeparatorOptions to prevent memory leak when outputColor is set via JSON config - Replace two exit(1) calls in ffPreparePublicIp with proper error status propagation, matching the pattern used in the weather module
- Add missing ffStrbufDestroy(&options->outputColor) in ffDestroySeparatorOptions to prevent memory leak when outputColor is set via JSON config - Replace two exit(1) calls in ffPreparePublicIp with proper error status propagation, matching the pattern used in the weather module
This reverts commit 18eef29.
…y allocation and potential attacks
The minimal (core) installation ships the `ubuntustudio-desktop-core` metapackage instead of `ubuntustudio-desktop`, so the existing check missed it and the system was reported as Kubuntu. Fixes #2485
removes `--gen-config-*` flags (merged into `--gen-config`)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist