Skip to content

FR-755 Update links to point to the correct pages#96

Merged
JuanVqz merged 1 commit into
mainfrom
FR-755-audit-nav
Jul 22, 2026
Merged

FR-755 Update links to point to the correct pages#96
JuanVqz merged 1 commit into
mainfrom
FR-755-audit-nav

Conversation

@FionaDL

@FionaDL FionaDL commented Jul 22, 2026

Copy link
Copy Markdown
Member

IMPORTANT: please be descriptive and provide all required information. Make sure you provide all the information needed for others to review your PR. On sections marked “if applicable”, if that section is not applicable make sure to delete it. Additionally, if your PR closes any open GitHub issues, make sure you include Closes #XXXX in your comment or use the option on the PR's sidebar to add related issues to auto-close the issue that your PR fixes.

What is this PR:

  • Bug fix
  • Feature
  • Chore

Description:

This PR updates the broken nav bar links to point to the correct ones in FastRuby.io

Screenshots:

If changes to the UI are made, please include screenshots of the before and after.

Related story:
https://ombulabs.atlassian.net/browse/FR-755

Related links (if applicable):

Link to any related issues.

How has this been tested?

  • Automated tests
  • Manual tests

What manual tests have been run?

Describe which manual tests did you run (you can copy paste from the description of the story in Pivotal Tracker) and their outcome (passed or fail). Also add any further details you feel are needed for others to reproduce your results and verify your results.

What browsers did you test it on (if applicable)?

  • Chrome
  • Firefox
  • Edge
  • Safari

What devices did you test it on (if applicable)?

  • Laptop / PC
  • Tablet
  • Mobile

@FionaDL
FionaDL requested a review from JuanVqz July 22, 2026 15:40
@FionaDL FionaDL changed the title Update links to point to the correct pages FR-755 Update links to point to the correct pages Jul 22, 2026

@JuanVqz JuanVqz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are updating links, I think we should take the opportunity to leave the navbar as FastRuby.io does.

Let me know if disagrees or so

Comment thread app/views/layouts/application.html.erb
Comment thread app/views/layouts/application.html.erb
Comment thread app/views/layouts/application.html.erb

@JuanVqz JuanVqz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JuanVqz
JuanVqz merged commit 072b474 into main Jul 22, 2026
2 checks passed
@JuanVqz
JuanVqz deleted the FR-755-audit-nav branch July 22, 2026 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants