Resolve the first Stryker survivor queue - #67
Merged
Conversation
Triaging the survivors of the two smallest scoped mutation runs produced four distinct outcomes, three of which are addressed here. The fourth — twelve survivors covering the target-provided branch of the typed validation OpenAPI helpers — is deferred to #57, because that branch passes a null message and testing it now would encode the bug as the expected contract. Two survivors turned out to be false. Applying them by hand fails 46 and 52 of 112 tests respectively, yet Stryker reports both as survived: they sit in code reachable only during static initialization, which a reused test host runs once per process. Document that as a blind spot, since the report alone cannot settle such a survivor. Three survivors are unkillable and now carry narrow suppressions with their justification on the directive line, where Stryker records it — a reason split across lines is silently truncated in the report. Three were genuine guard-clause gaps: no test invoked the typed helpers on a null builder or ExecuteResultAsync on a null context, where the guards are what turn a NullReferenceException into the documented ArgumentNullException. Closes #66 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0184eh1G3XxvjRB11cNKyMRT
Minimum allowed line rate is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Triaging the survivors of the two smallest scoped mutation runs produced four distinct outcomes, three of which are addressed here. The fourth — twelve survivors covering the target-provided branch of the typed validation OpenAPI helpers — is deferred to #57, because that branch passes a null message and testing it now would encode the bug as the expected contract.
Two survivors turned out to be false. Applying them by hand fails 46 and 52 of 112 tests respectively, yet Stryker reports both as survived: they sit in code reachable only during static initialization, which a reused test host runs once per process. Document that as a blind spot, since the report alone cannot settle such a survivor.
Three survivors are unkillable and now carry narrow suppressions with their justification on the directive line, where Stryker records it — a reason split across lines is silently truncated in the report.
Three were genuine guard-clause gaps: no test invoked the typed helpers on a null builder or ExecuteResultAsync on a null context, where the guards are what turn a NullReferenceException into the documented ArgumentNullException.
Closes #66
Claude-Session: https://claude.ai/code/session_0184eh1G3XxvjRB11cNKyMRT