Repository navigation
chore: bump @seamless-auth/types to 0.33 and read the dry run capped flag - #316
Merged
Merged
Conversation
…flag The Sign-in Policy dry run now shows its account limit notice from the API's capped field. When an older API omits it, the page falls back to inferring the cap from usersEvaluated plus breakGlassAccounts. The local capped extension of PolicyDryRunResponse is replaced by the upstream type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #314.
@seamless-auth/types0.33.0 adds optionalPolicyDryRunResponse.capped, and the auth API returns it as of fells-code/seamless-auth-api#505.Changes
@seamless-auth/typesto^0.33.0.capped. Whencappedis absent (an older API), it still infers the cap fromusersEvaluated + breakGlassAccounts >= 10000. An explicitcapped: falseis trusted over the counts.PolicyDryRunReporttype (acapped?extension ofPolicyDryRunResponse) in favour of the upstream type.makePolicyDryRunfactory returnscapped: false, matching the current API.Other 0.33 additions (
MeResponse.recovery, the recovery schemas) need no changes here. The console has no local copies of them.Checks
npm run lint,npm run typecheck,npm run format:check: cleannpm test: 99 files, 671 tests passednpx playwright test e2e/tests/policy.spec.ts: 6 passednpm run build: oknpm run check:types-current:^0.33.0is current