Repository navigation
fix: bind provider lookups to the asking client's grant when a session has several - #524
Merged
Merged
Conversation
This was referenced Oct 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
hasOidcGrantForSessionread oneGrantrow for the session and then compared itsclientId. A first-party session signed in to more than one client holds one grant per client, so the row that came back could belong to another client and the check failed./oidc/sign,GET /oidc/accounts/:idandGET /oidc/sessions/:id/auth-contextall go through it, so the second app a user signs in to from the hosted pages would be refused.The client is now part of the query (
payload.clientId, a JSONB match). The equality check after it stays as a second guard.Why now
The login edge (seamless-auth-oidc-provider#2) keeps one first-party session across apps, which is exactly the case this broke. Found while wiring interactions there.
Part of #387. Small and on its own, so it can merge independently of the other v0.21 API work.
Checks
TEST_DB=postgres npx vitest run --project postgres: 48 passednpm run typecheck,npm run lint,prettier --check src tests: cleannpm run coverage: 2536 passed, 98.99% lines, 95.69% branches