Repository navigation
feat: add admin management of OpenID Provider resources and scopes - #526
Merged
Merged
Conversation
Bccorb
force-pushed
the
feat/oidc-resources
branch
from
October 31, 2026 01:10
e38b8ec to
ea63a98
Compare
Bccorb
marked this pull request as ready for review
October 31, 2026 01:11
Bccorb
force-pushed
the
feat/oidc-resources
branch
from
October 31, 2026 01:29
ea63a98 to
31dc8c9
Compare
This was referenced Oct 31, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #525 (feat/oidc-applications). Review that one first.
What
Admin management of OpenID Provider resources and scopes (#509, ADR 0001 D5 and D11). Reads need
admin:read. Writes needadmin:writeplus a fresh step-up and are audited.GET,POST /admin/resourcesGET,PATCH,DELETE /admin/resources/:idGET,PUT /admin/applications/:id/resourcesaudof the resource's access tokens and cannot change. It cannot be the APIISSUERoroidc_issuer.seamlessare reserved.POST /oidc/signalready checks (getOidcClientResourceScopes), soaudequals the resource andscopeis a subset of the application's grant. A Postgres test covers the path from the admin writes to that lookup.Contract change. These are new access passthroughs for seamless-auth-server#241, dashboard#296 and cli#276.
Types
Locks the published
@seamless-auth/types0.34.0-next.1 (fells-code/seamless-auth-types#125).Part of #509
Checks (local, against the published types 0.34.0-next.1)
npm run typecheck,npm run lint,npm run format:check,npm run build: passnpm run coverage: 166 files, 2615 tests pass; 99.02% lines, 95.72% branchesTEST_DB=postgresproject on a scratch Postgres 16: 49 tests pass/security-reviewover both commits: no findings