Repository navigation
feat(oidc): send per-application token lifetimes to the provider service - #539
Merged
Merged
Conversation
Bccorb
marked this pull request as ready for review
November 1, 2026 01:26
Bccorb
force-pushed
the
feat/oidc-client-token-ttls
branch
2 times, most recently
from
November 1, 2026 02:01
2511374 to
a222dff
Compare
…clients (#540) * feat(oidc): let a confidential application opt out of PKCE * feat(oidc): per-application nonce requirement for clients without PKCE --------- Co-authored-by: Brandon Corbett <Bccorb@users.noreply.github.com>
Bccorb
force-pushed
the
feat/oidc-client-token-ttls
branch
from
November 1, 2026 02:12
a222dff to
5d5d02a
Compare
This was referenced Nov 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per-application token lifetimes for the OpenID Provider (epic #387). Stacked on #538. Also carries the per-application PKCE and nonce opt-outs from #540, which was merged into this branch. Uses
@seamless-auth/types0.34.0-next.4 (fells-code/seamless-auth-types#140 adds the fields).What changed
accessTokenTtlSeconds,idTokenTtlSecondsandrefreshTokenTtlSecondsare stored inoidc_clientsand set through the admin routes, but they never reached the provider service, so they did nothing.GET /oidc/clients/:idnow sends them asurn:seamless:access_token_ttl,urn:seamless:id_token_ttlandurn:seamless:refresh_token_ttl, leaving out the ones that are unset./oidc/sign's 24 h ceiling, and refresh tokens to 5 min to 90 days, which matches the payload store's 90 day ceiling.Checks (against types 0.34.0-next.4)
npm run typecheck,npm run lint,npm run format:check: cleannpm run test:run: 2732 passed