Repository navigation
ci: skip docs-only changes without dropping the required check, add timeouts - #121
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #119. Part of fells-code/seamless-auth-api#387 (wave 0, needs no release).
mainis covered by a ruleset that requires theLint, typecheck, test, buildcheck, sopaths-ignoreon the trigger would leave that check unreported on a documentation-only PR and block the merge forever. Instead:changesjob lists the PR's files through the API and decides whether anything outside documentation (*.md,docs/**,LICENSE,.github/ISSUE_TEMPLATE/**) changed. Pushes always count as code.cijob runs only whenchangessays so.ci-result(the required check) always runs: it requireschangesto succeed and the matrix to besuccessorskipped. A README-only PR therefore runs no test jobs but still reports the required check green.timeout-minuteson every job (matrix 20, release 20, helper jobs 5).concurrencyalready existed onci.yml.actionlint, lint and format:check pass locally. The file-filter shell was tested locally against docs-only and mixed file lists. Worth confirming on this PR that the required check still reports.