fix: use fs.rm instead of fs.rmdir, update minimum node version - #40
Open
Dadadah wants to merge 1 commit into
Open
fix: use fs.rm instead of fs.rmdir, update minimum node version#40Dadadah wants to merge 1 commit into
Dadadah wants to merge 1 commit into
Conversation
Signed-off-by: Jacob Schlecht <dadadah@echoha.us>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fs.rmdir no longer supports the
recursiveoption as of node 25. This PR changes doZip to use fs.rm instead.This PR increases the minimum node version to 14.14.0. This was already the case as this repo used fs.rmsync before, so the minimum was incorrect.
#38 results in zip electron builds in electron-forge failing on windows with node >= 25.
Fixes #38