Patch the vendored NativePHP plugin from a stored stock copy

[fgilio]

Why

Every patch in scripts/patch-nativephp.php anchored on the text the previous revision of the script left behind. Changing a patch meant adding an upgrade path from its old output, and the review of #184, #185, and #186 found three such paths missing:

• Rebuild the framework caches in the background after an update #184: the old optimize block carried launch-timeline marks the upgrade anchor did not include, so an already-patched vendor tree blocked the run.
• Load main-process externals lazily and cache the login shell PATH #185: the old axios import stayed in place next to the new one, so Composer wrote a module with two axios bindings and no error.
• Send the opcache warm-up from a worker thread the moment PHP is spawned #186: the boot block installed by Load main-process externals lazily and cache the login shell PATH #185 was never replaced, so the set refused the update.

What

The runner keeps a copy of each stock target under vendor/nativephp/desktop/.rfa-stock on the first run over a fresh vendor tree. Every later run patches that copy and writes the result over the live file, so a patch only ever anchors on stock or on the output of an earlier patch in the same run.

• A target without rfa edits is stock. It becomes the stored copy when the stored one is missing or differs, which covers a reinstalled or upgraded plugin.
• A patched target with no stored copy comes from a script revision that kept none. The run is refused with the reinstall command instead of guessing.
• The copies live inside the package so Composer drops them with it, and outside resources/electron, which the build copies whole.

Existing checkouts patched by an earlier revision need one reinstall: rm -rf vendor/nativephp/desktop && composer install.

Related

• Rebuild the framework caches in the background after an update #184
• Load main-process externals lazily and cache the login shell PATH #185
• Send the opcache warm-up from a worker thread the moment PHP is spawned #186

🤖 Generated with Claude Code

https://claude.ai/code/session_01RqwYa86be82YSKkJYb9VLz

[coderabbitai]

Warning

Review limit reached

Next included review available in 9 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: 80f499e4-64d0-47f1-b674-26565c027b12

📥 Commits

Reviewing files that changed from the base of the PR and between 50bb973 and cc80948.

📒 Files selected for processing (3)

• .github/workflows/ci.yml
• scripts/patch-nativephp.php
• tests/Unit/Scripts/NativePhpPatchSetTest.php

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.