Repository navigation
INTER-2921: test: run functional tests on a 29-day window and enable ruleset checks in CI - #313
Conversation
Test workspaces on the default data retention reject search start times older than 30 days. The tests only need recent events, so a 29-day window works on any retention.
|
Coverage report
Test suite run success137 tests passing in 32 suites. Report generated by 🧪jest coverage report action from d84f5b3 Show full coverage report
|
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the functional-test search window adjustment to 29 days.
No open issues 🎉
What changed in this PR
This PR narrows the functional tests’ event search window to avoid rejection by workspaces with the default 30-day data retention.
Changes:
- Reduces the search window from 89 days to 29 days, also narrowing the oldest-event check.
- Updates the inline comment to explain the retention constraint.
| File | Description |
|---|---|
tests/functional-tests/functionalTests.mjs |
Uses a 29-day event search window and updates its explanatory comment. |
Review effort: Balanced
Pass RULESET_ID to the functional tests and check rule_id by shape, so a recreated ruleset needs only the secret updated.
pnpm exec changesetto create a changeset. |
Ticket: INTER-2921
Why
Test workspaces on the default data retention reject event searches older than 30 days, and the ruleset checks never ran in CI because
RULESET_IDwasn't passed.Things to note
RULESET_IDsecret updated.Verification
node functionalTests.mjslocally against the test workspace withRULESET_IDset: all checks passed, including both ruleset checks.Change outline