Skip to content

INTER-2921: ci: seed identification events before functional tests - #314

Merged
JuroUhlar merged 1 commit into
mainfrom
test-seed-identification-events
Nov 17, 2026
Merged

JuroUhlar merged 1 commit into
mainfrom
test-seed-identification-events

Conversation

@JuroUhlar

@JuroUhlar JuroUhlar commented Nov 17, 2026 •

Copy link
Copy Markdown
Collaborator

Ticket: INTER-2921

The test workspace keeps data for only 30 days and gets no other traffic, so the functional tests need fresh identification events to run against.

  • Add a seed_events job to the functional tests workflow that runs the shared seed-identification-events action from dx-team-toolkit.
  • Make functional_tests depend on it (needs: [build, seed_events]).

@changeset-bot

changeset-bot Bot commented Nov 17, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: ce0c358

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

Copy link
Copy Markdown
Contributor

⚠️ This PR doesn't contain any changesets. If there are user-facing changes, don't forget to run:

pnpm exec changeset

to create a changeset.

@github-actions

Copy link
Copy Markdown
Contributor

Coverage report

St.❔
Category Percentage Covered / Total
🟢 Statements 98.25% 168/171
🟢 Branches 97.03% 98/101
🟢 Functions 100% 37/37
🟢 Lines 98.21% 165/168

Test suite run success

137 tests passing in 32 suites.

Report generated by 🧪jest coverage report action from ce0c358

Show full coverage report
St File % Stmts % Branch % Funcs % Lines Uncovered Line #s
🟢 All files 98.24 97.02 100 98.21
🟢  src 98.54 98.76 100 98.51
🔴   ...edApiTypes.ts 0 0 0 0
🔴   index.ts 0 0 0 0
🟢   sealedResults.ts 100 100 100 100
🟢   ...rApiClient.ts 96.15 97.22 100 96.15 364,368
🟢   types.ts 100 100 100 100
🟢   urlUtils.ts 100 100 100 100
🟢   webhook.ts 100 100 100 100
🟢  src/errors 97.05 90 100 96.96
🟢   apiErrors.ts 100 100 100 100
🟢   ...orResponse.ts 100 100 100 100
🟢   toError.ts 87.5 88.88 100 87.5 21
🟢   unsealError.ts 100 50 100 100 14

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues block the functional-test CI event-seeding change.

No open issues 🎉

What changed in this PR

Updates functional-test CI to seed fresh identification events before running the live tests, addressing the test workspace’s 30-day data retention.

Changes:

  • Adds a seed_events job using the shared seed-identification-events@v1 action and FINGERPRINT_PUBLIC_KEY secret.
  • Makes functional tests depend on both the build and event-seeding jobs.
File Description
.github/​workflows/​functional_tests.yml Adds event seeding and requires it to complete before functional tests run.

Review effort: Balanced

@JuroUhlar
JuroUhlar marked this pull request as ready for review November 17, 2026 22:13
@JuroUhlar
JuroUhlar merged commit 73d4913 into main Nov 17, 2026
29 of 31 checks passed
@JuroUhlar
JuroUhlar deleted the test-seed-identification-events branch November 17, 2026 22:36
@JuroUhlar JuroUhlar changed the title ci: seed identification events before functional tests INTER-2921: ci: seed identification events before functional tests Nov 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants