chore(deps): update Rust major dependencies - #683
Merged
Conversation
Takes the major bumps from the renovate/major-rust branch (#612): tuirealm 3 -> 4.1.0 tui-realm-stdlib 3 -> 4.1.0 tui-realm-textarea 2 -> 4.1.0 usage-lib 2 -> 6.1.1 toml 0.9.8 -> 1.1.4 No source changes were needed. Despite spanning a TUI framework major and a four-major jump in usage-lib, the workspace compiles clean with no errors and no clippy warnings. That PR could not land as-is for the same reason as #638: Renovate's lockfile regeneration was failing, so it carried manifest bumps with no Cargo.lock, which CI now rejects via --locked. Resolution works now that #677 and #679 have unwedged the dependency graph. Verified locally against the committed lockfile with --locked: fmt, clippy -D warnings, tests, and release builds for both morphir and morphir-live, including the morphir-live desktop build. All ten pass.
✅ Deploy Preview for angry-raman-7c44f6 canceled.
|
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rust major dependency updates, taken from Renovate's
renovate/major-rustbranch (#612) and carried to green.Supersedes #612.
tuirealmtui-realm-stdlibtui-realm-textareausage-libtomlNo source changes required
Worth stating plainly, because it's surprising: despite spanning a TUI framework major and a four-major jump in
usage-lib, the workspace compiles clean — no errors, no clippy warnings, no source edits. This is a manifest-and-lockfile-only change.I verified the versions genuinely moved in
Cargo.lockrather than silently staying put, since a no-op would produce the same green result.Contrast with #679, where
starbase0.10→0.13 needed a real migration across 12 files.Why #612 couldn't land as-is
Same root cause as #638: Renovate's lockfile regeneration was failing ("Artifact file update failure"), so it carried manifest bumps with no
Cargo.lock— which CI rejects since #678 added--locked.Resolution works now that #677 and #679 have unwedged the dependency graph. Before #677 nothing here could resolve at all.
Verification
Every CI cargo step run locally with
--locked:cargo fmt --checkcargo clippy --locked --all-targets -- -D warningscargo test --lockedcargo build --locked --releasecargo build --locked --release --features desktopPlus
cargo test --locked --workspace— pass. 10/10.Kept separate from #679 so the TUI and
usage-libmajors stay independently reviewable and revertable.