Fix Android setup eval expectations and reference lateinit shadowing bugs. - #180
Merged
Merged
Conversation
…bugs. Addresses Android evaluation expectation and reference issues from cl/982615455: - `firebase_basics/EVAL.txtpb`: Update Google Maven metadata URL for `google-services` plugin to `dl.google.com/dl/android/maven2/com/google/gms/google-services/maven-metadata.xml` (fixing 404 group path). - `firebase_crashlytics/EVAL.txtpb`: Add `firebase-bom` dependency check in `android_crashlytics_gradle_and_test_crash` and allow Firebase Console URL with or without `/u/0/`. - `firebase_auth_basics/EVAL.txtpb`: Clarify `android_auth_email_password_setup` expectation to require initializing `auth` property without local `val` shadowing. - `firebase_auth_basics/references/client_sdk_android.md` & `firebase_firestore/references/standard/android_sdk_usage.md`: Fix `val auth = Firebase.auth` / `val db = Firebase.firestore` local variable shadowing of `lateinit var` properties in `AppCompatActivity.onCreate()`. PiperOrigin-RevId: 982679285
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
christhompsongoogle
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Android setup eval expectations and reference lateinit shadowing bugs.
Addresses Android evaluation expectation and reference issues from cl/982615455:
firebase_basics/EVAL.txtpb: Update Google Maven metadata URL forgoogle-servicesplugin todl.google.com/dl/android/maven2/com/google/gms/google-services/maven-metadata.xml(fixing 404 group path).firebase_crashlytics/EVAL.txtpb: Addfirebase-bomdependency check inandroid_crashlytics_gradle_and_test_crashand allow Firebase Console URL with or without/u/0/.firebase_auth_basics/EVAL.txtpb: Clarifyandroid_auth_email_password_setupexpectation to require initializingauthproperty without localvalshadowing.firebase_auth_basics/references/client_sdk_android.md&firebase_firestore/references/standard/android_sdk_usage.md: Fixval auth = Firebase.auth/val db = Firebase.firestorelocal variable shadowing oflateinit varproperties inAppCompatActivity.onCreate().