fix(storage-resize-images): label the IS_ANIMATED true option Yes - #3147
Closed
IzaakGough wants to merge 2 commits into
Closed
fix(storage-resize-images): label the IS_ANIMATED true option Yes#3147IzaakGough wants to merge 2 commits into
IzaakGough wants to merge 2 commits into
Conversation
The kit labelled it `True`; `extension.yaml` labels it `Yes`. Only the deploy-time prompt is affected, the stored values are unchanged. The param audit tests pinned option values but not labels, so add an assertion covering both.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request fixes a label typo in the IS_ANIMATED configuration option for the storage-resize-images kit, changing the label from 'True' to 'Yes' to match the deploy-time prompt. It also adds a corresponding unit test to verify that the option labels and values are correctly declared. I have no feedback to provide.
IzaakGough
marked this pull request as ready for review
September 8, 2026 10:41
Member
|
Superseded by #3148 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3123.
kits/storage-resize-images/src/config.tsdeclared theIS_ANIMATEDtrue option asTrue, whilestorage-resize-images/extension.yamllabels itYes. Only the deploy-time prompt is affected: the stored values aretrue/falseeither way, so no.envfrom an earlier deploy needs editing.The param audit tests pinned option values but not labels, which is how it slipped through, so this also adds an
IS_ANIMATED selecttest that reads the param out ofdeclaredParamsand asserts labels and values together.Verified by generating the params spec the CLI reads at deploy time (
loadStackover the builtlib/) and diffing its options against the ones parsed out ofextension.yaml: they now match exactly. Full kit suite passes (183 passed, 3 skipped, the skips being the pre-existing live Vertex AI content-filter tests). I also mutated the declaration seven ways (label typo, stringified value, extra option, reordered options, labels dropped, param renamed, select input removed) and confirmed the new test fails on each, rather than passing whichever way the labels went.CONTENT_FILTER_LEVEL's"Off (No filtering)": "False"mapping is untouched here, it belongs to #3064.