Promote prefer-promise-reject-errors to error and fix violations

.eslintrc.js

@@ -31,7 +31,6 @@ module.exports = {
       },
     ],
     "no-useless-escape": "warn", // TODO(bkendall): remove, allow to error.
-    "prefer-promise-reject-errors": "warn", // TODO(bkendall): remove, allow to error.
   },
   overrides: [
     {

src/emulator/commandUtils.ts

@@ -83,7 +83,7 @@
  * specify an emulator address.
  */
 export function printNoticeIfEmulated(
   options: any,
   emulator: Emulators.DATABASE | Emulators.FIRESTORE,
 ): void {
   if (emulator !== Emulators.DATABASE && emulator !== Emulators.FIRESTORE) {
@@ -111,7 +111,7 @@
  * an emulator port that the command actually talks to production.
  */
 export async function warnEmulatorNotSupported(
   options: any,
   emulator: Emulators.DATABASE | Emulators.FIRESTORE,
 ): Promise<void> {
   if (emulator !== Emulators.DATABASE && emulator !== Emulators.FIRESTORE) {
@@ -138,8 +138,8 @@
   }
 }
 
 export async function errorMissingProject(options: any): Promise<void> {
   if (!options.project) {
     throw new FirebaseError(
       "Project is not defined. Either use `--project` or use `firebase use` to set your active project.",
     );
@@ -150,12 +150,12 @@
  * Utility method to be inserted in the "before" function for a command that
  * uses the emulator suite.
  */
 export async function beforeEmulatorCommand(options: any): Promise<any> {
   const optionsWithDefaultConfig = {
     ...options,
     config: DEFAULT_CONFIG,
   };
   const optionsWithConfig = options.config ? options : optionsWithDefaultConfig;
 
   // We want to be able to run most emulators even in the absence of
   // firebase.json. For Functions and Hosting we require the JSON file since the
@@ -336,7 +336,7 @@
       res();
     } catch (e: unknown) {
       logger.debug(e as any);
-      rej();
+      rej(getError(e));
     }
   };
 }
@@ -394,7 +394,11 @@
   return new Promise((resolve, reject) => {
     proc.on("error", (err: any) => {
       utils.logWarning(`There was an error running the script: ${JSON.stringify(err)}`);
-      reject();
+      reject(
+        new FirebaseError("There was an error running the script.", {
+          original: err instanceof Error ? err : undefined,
+        }),
+      );
     });
 
     // Due to the async nature of the node child_process library, sometimes
@@ -406,7 +410,9 @@
     proc.once("exit", (code, signal) => {
       if (signal) {
         utils.logWarning(`Script exited with signal: ${signal}`);
-        setTimeout(reject, exitDelayMs);
+        setTimeout(() => {
+          reject(new FirebaseError(`Script exited with signal: ${signal}`));
+        }, exitDelayMs);
         return;
       }
 

src/emulator/dataconnectEmulator.ts

@@ -175,7 +175,11 @@ export class DataConnectEmulator implements EmulatorInstance {
         "dataconnect",
         "Could not connect to SQL Connect emulator. Check dataconnect-debug.log for more details.",
       );
-      return Promise.reject();
+      return Promise.reject(
+        new FirebaseError(
+          "Could not connect to SQL Connect emulator. Check dataconnect-debug.log for more details.",
+        ),
+      );
     }
     return Promise.resolve();
   }

src/emulator/eventarcEmulator.ts

@@ -168,7 +168,9 @@ export class EventarcEmulator implements EmulatorInstance {
   async triggerEventFunction(channel: string, event: CloudEvent<any>): Promise<void[]> {
     if (!EmulatorRegistry.isRunning(Emulators.FUNCTIONS)) {
       this.logger.log("INFO", "Functions emulator not found. This should not happen.");
-      return Promise.reject();
+      return Promise.reject(
+        new FirebaseError("Functions emulator not found. This should not happen."),
+      );
     }
     const key = `${event.type}-${channel}`;
     const triggers = this.events[key] || [];

src/emulator/workQueue.spec.ts

@@ -130,7 +130,7 @@ describe("WorkQueue", () => {
       let hasRun1 = false;
       const work1 = () => {
         hasRun1 = true;
-        return Promise.reject();
+        return Promise.reject(new Error("job failed"));
       };
 
       let hasRun2 = false;

src/profileReport.ts

@@ -555,8 +555,14 @@ export class ProfileReport {
           }
         }
       });
-      rl.on("error", () => {
-        reject();
+      rl.on("error", (err) => {
+        reject(
+          err instanceof Error
+            ? err
+            : new FirebaseError("There was an error creating the report.", {
+                original: err as any,
+              }),
+        );
       });
       outStream.on("error", () => {
         errored = true;

src/throttler/throttler.spec.ts

@@ -168,7 +168,7 @@ const throttlerTest = (ThrottlerConstructor: ThrottlerConstructorType): void =>
       if (count > 2) {
         return Promise.resolve();
       }
-      return Promise.reject();
+      return Promise.reject(new Error("retry"));
     };
 
     const q = new ThrottlerConstructor({

src/utils.spec.ts

@@ -206,6 +206,7 @@ describe("utils", () => {
     it("should settle all promises", async () => {
       const result = await utils.promiseAllSettled([
         Promise.resolve("foo"),
+        // eslint-disable-next-line prefer-promise-reject-errors
         Promise.reject("bar"),
         Promise.resolve("baz"),
       ]);
@@ -322,6 +323,7 @@ describe("utils", () => {
 
     it("waits for all settled", async () => {
       // Intetionally failing with a non-error to make matching easier
+      // eslint-disable-next-line prefer-promise-reject-errors
       const reject = Promise.reject("fail fast");
       const resolve = new Promise((res) => {
         setTimeout(() => res(42), 20);