Repository navigation
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new command run:services:update (gated behind the direct_cloud_run experiment) to update, rebuild, and redeploy Cloud Run services, specifically supporting setting or clearing a base image. Feedback on the changes suggests: (1) iterating through all configurations returned by getServiceConfigs to properly support multi-region setups instead of only checking the first one, (2) gracefully handling cases where config.region is undefined in missingServiceMessage to prevent printing 'undefined' to users, and (3) using defensive assignment (|| {}) when initializing client.run namespaces to avoid overwriting existing properties.
falahat
added this pull request to stack #11209
September 30, 2026 04:19
falahat
force-pushed
the
bapi_services_update
branch
from
September 30, 2026 04:20
51f4259 to
595ee57
Compare
falahat
force-pushed
the
bapi_services_update
branch
from
September 30, 2026 21:37
1608f73 to
9a8b7ca
Compare
falahat
removed this pull request from stack #11209
September 30, 2026 21:42
falahat
added this pull request to stack #11226
October 2, 2026 16:41
Clearing a base image that isn't set no longer skips the deploy. run:services:update always rebuilds and deploys, the same as firebase deploy, instead of trying to detect no-op updates.
# Conflicts: # scripts/run-deploy-tests/tests.ts
firebase run:services:update <serviceId> now also accepts <serviceId>:<region>. - If firebase.json lists the service ID once, the region is optional. - If it lists the ID in more than one region, the command fails and lists the <serviceId>:<region> names to choose from. - It deploys only run:<serviceId>:<region>, so it never redeploys the same ID in another region. The "doesn't exist yet" message also suggests the command that deploys just that service and region.
Also drops update's own missing-region check, which getAllServiceConfigs now does for every service, and puts run:services:update back in the deploy help text.
- Read the flags into a settings object and pass it straight to deploy. - Move the missing-service message into update.ts, its only caller. - Tests: realistic names, an update() helper that reads like the CLI call, one expectDeployed() helper, and one test for the always-rebuild decision.
falahat
removed this pull request from stack #11226
October 12, 2026 15:21
falahat
added this pull request to stack #11267
October 12, 2026 15:22
falahat
commented
Oct 12, 2026
updateService took one name that was either <serviceId> or <serviceId>:<region>. It now takes serviceId and region, and the command takes the region from --region.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Scenarios Tested
Sample Commands