Deprecate redundant global functions and add Swift standard library redundancy tests - #61
Merged
Conversation
ctreffs
marked this pull request as ready for review
August 24, 2026 09:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR deprecates global scalar math functions (
abs,min,max) that conflict with the Swift Standard Library and introduces a dedicated test suite (SwiftStandardLibraryRedundancyTests) to verify equivalence between FirebladeMath functions and native Swift / platform math APIs across all supported platforms.What Changed
abs(_ x: Float)/abs(_ x: Double)with@_disfavoredOverloadand@available(*, deprecated, message: "Use Swift.abs(_:) or x.magnitude instead.", renamed: "Swift.abs").min(_ x: Float, _ y: Float)/min(_ x: Double, _ y: Double)with@_disfavoredOverloadand@available(*, deprecated, message: "Use Swift.min(_:_:) instead.", renamed: "Swift.min").max(_ x: Float, _ y: Float)/max(_ x: Double, _ y: Double)with@_disfavoredOverloadand@available(*, deprecated, message: "Use Swift.max(_:_:) instead.", renamed: "Swift.max").clamp.swiftandfract.swiftto explicitly invokeSwift.min/Swift.max.Tests/FirebladeMathTests/SwiftStandardLibraryRedundancyTests.swiftverifying equivalence for:abs,min,max)FloatingPointprotocol methods (squareRoot,rounded,init(signOf:magnitudeOf:),truncatingRemainder, classification checks)SIMDvector operations (Array(simd),SIMD.clamped,(v1 * v2).sum()dot product,isNaN)Why
Swift.abs,Swift.min, andSwift.max.-Xswiftc -warnings-as-errors).Testing Steps
swift build -Xswiftc -warnings-as-errorsswift test -Xswiftc -warnings-as-errors(All 278 tests across 22 suites pass)Risk of Regression
@_disfavoredOverloadpreserving existing call sites while steering callers towards Swift standard library primitives.