Fall back to the stored id when one entity pointer's Git identity is unreadable - #688
Merged
Merged
Conversation
…unreadable A registered pointer under a TCC-protected directory makes git rev-parse fail with Operation not permitted, so plan_identity_parts raised and _identity_index refused the portfolio refresh, shadow read, and shadow throw for every entity. Quarantine that pointer for the cycle the way the board importer quarantines an unreadable local plan: keep the stored id, print one stderr notice per pointer, and let every healthy peer index.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
_identity_indexinscripts/shadow_root_board.pycallsentity_id()on every registered pointer. When one pointer's plan lives where the process cannot read it (a TCC-protected~/Documentscheckout on this Mac),plan_identity_partsraisesBoardError("project Git identity could not be read")and the whole portfolio refresh,shadow read, andshadow throwrefuse for all 46 entities, blaming Git.Change
One unreadable pointer now falls back to its stored id for that cycle and prints a quarantine notice once per pointer per process, matching the local-plan quarantine precedent in
shadow_board_import.py. The docstring already declared stored ids the fallback for missing plans; this extends it to unreadable ones.Proof
tests.test_root_board.OneUnreadablePointerNeverBlanksThePortfolio: red before the change (3 errors at the real refusal site), green after (Ran 3 tests ... OK).test_status_fast_path test_status_focus test_throw test_plan_read test_style_guard test_shadow_lint test_public_ready_grep_gate->Ran 278 tests ... OK.ADegradedPortfolioReadNamesItsTrueCausepasses unchanged.Known, out of scope
ProjectMapMigrationIsAtomicAndReversiblefails 11/12 on cleanorigin/main(6a40b1f) on this machine becauseSHADOW_TELEMETRY=localis exported in the operator's shell and the test harness passesos.environthrough, so telemetry writes dirty the scratch checkout the migration requires clean. With the variable unset the class passes 12/12. Not caused by this branch; a separate test-harness PR scrubs the variable.Contract note for review
A failed refresh used to be named board-wide as STALE. This change converts one unreadable pointer into a per-entity notice plus stored-id fallback, so that entity may sit on a stale id while the board prints as current. Reviewer call whether the notice is loud enough.