Don't cast enum type with string backed enums. - #880
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was just trying this project out with a laravel application, and it seems to work pretty well but it broke discovering most of my models as I often use string backed enums.
It seems (via #572) the OData spec doesn't allow for string backed enums so there is no way to support this - so I propose this change to set string enums to the string type by default rather then breaking by forcing into an enum that expects an int.
I couldn't work out the tests, but it works on my laravel application. ReflectionEnum is only in ^8.1 but the EnumerationType::isEnum checks the php version already so it shouldn't hit that on lower versions.