Repository navigation
Complete user stanza support - #11
Draft
navaneeth-dev wants to merge 3 commits into
Draft
navaneeth-dev wants to merge 3 commits into
navaneeth-dev wants to merge 3 commits into
Conversation
navaneeth-dev
requested review from
elmiko and
tormath1
and
a balanced review from Copilot
October 4, 2026 06:59
Convert supplementary and primary groups, password-lock policy, and sudo rules into equivalent Flatcar Butane configuration. Reject unrepresentable inactive accounts and unsafe generated-configuration usernames. Signed-off-by: Navaneeth <me@rizexor.com>
Signed-off-by: Navaneeth <me@rizexor.com>
Require an explicit primary group when a synthesized group matches a configured username. This prevents Ignition user creation from colliding with Linux private-group creation. Signed-off-by: Navaneeth <me@rizexor.com>
navaneeth-dev
force-pushed
the
feat/users-support
branch
from
October 4, 2026 07:01
587922e to
b890ea0
Compare
elmiko
reviewed
Oct 5, 2026
elmiko
left a comment
elmiko
left a comment
Collaborator
There was a problem hiding this comment.
this is making sense to me, i have a minor question.
also, the documentation work is great, makes it very clear to see the state of the various cloud-init fields. well done!
Comment on lines
+85
to
+87
| config.Passwd.Groups = users.Groups | ||
| config.Passwd.Users = users.Users | ||
| config.Storage.Files = users.Files |
Collaborator
There was a problem hiding this comment.
do we need any sort of check on the right hand values? (eg detect nil or similar)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.