Bump the dependencies - #37
Conversation
Signed-off-by: Krzesimir Nowak <knowak@microsoft.com>
Hopefully, this will make a future diff a bit smaller. Signed-off-by: Krzesimir Nowak <knowak@microsoft.com>
We still use v2 API of etcd. The v2.305.33 version is only for the client of the v2 API, which encodes that it came from v3.5.33 (which at the moment of this commit creation, is the latest patch release of v3.5 branch, that still contains the v2 API client). Signed-off-by: Krzesimir Nowak <knowak@microsoft.com>
Signed-off-by: Krzesimir Nowak <knowak@microsoft.com>
Signed-off-by: Krzesimir Nowak <knowak@microsoft.com>
Signed-off-by: Krzesimir Nowak <knowak@microsoft.com>
We only used the context package of the module, which is superseded by the context package from go's standard library. Signed-off-by: Krzesimir Nowak <knowak@microsoft.com>
There was a problem hiding this comment.
🔵 Needs a closer look
Unresolved critical and moderate findings remain in runtime compatibility, JSON flushing, and FreeBSD credentials.
Pull request overview
Updates Go to 1.26 and refreshes etcd, go-systemd, coreos/pkg, godbus, JSON, reflection, and syscall dependencies while migrating to standard-library context.
Changes:
- Updates Go and vendored dependencies.
- Migrates etcd usage and removes obsolete context, grpc, and protobuf dependencies.
- Refreshes platform, D-Bus, JSON, and reflection implementations.
File summaries
| File | Reviewed change |
|---|---|
vendor/golang.org/x/sys/unix/zptrace_x86_linux.go |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/zptrace_mipsnnle_linux.go |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/zptrace_mipsnn_linux.go |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/zptrace_linux_arm64.go |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/zptrace_armnn_linux.go |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/vgetrandom_unsupported.go |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/vgetrandom_linux.go |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/unveil_openbsd.go |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/sysvshm_unix.go |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/sysvshm_unix_other.go |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/sysvshm_linux.go |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/syscall_unix_gc.go |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/syscall_unix_gc_ppc64x.go |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/syscall_solaris_amd64.go |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/syscall_openbsd_riscv64.go |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/syscall_openbsd_ppc64.go |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/syscall_openbsd_mips64.go |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/syscall_openbsd_libc.go |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/syscall_openbsd_arm64.go |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/syscall_openbsd_arm.go |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/syscall_openbsd_amd64.go |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/syscall_openbsd_386.go |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/syscall_netbsd_arm64.go |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/syscall_netbsd_arm.go |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/syscall_netbsd_amd64.go |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/syscall_netbsd_386.go |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/syscall_linux_gccgo_arm.go |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/syscall_linux_gccgo_386.go |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/syscall_linux_gc.go |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/syscall_linux_gc_arm.go |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/syscall_linux_gc_386.go |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/syscall_linux_amd64_gc.go |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/syscall_linux_alarm.go |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/syscall_hurd.go |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/syscall_hurd_386.go |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/syscall_freebsd_riscv64.go |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/syscall_freebsd_arm64.go |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/syscall_freebsd_arm.go |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/syscall_freebsd_amd64.go |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/syscall_freebsd_386.go |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/syscall_dragonfly_amd64.go |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/syscall_darwin_libSystem.go |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/syscall_darwin_arm64.go |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/syscall_darwin_amd64.go |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/syscall_aix_ppc.go |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/sockcmsg_zos.go |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/sockcmsg_unix_other.go |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/sockcmsg_dragonfly.go |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/readdirent_getdirentries.go |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/readdirent_getdents.go |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/race0.go |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/race.go |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/ptrace_ios.go |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/ptrace_darwin.go |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/pagesize_unix.go |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/mremap.go |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/mmap_nomremap.go |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/ioctl_zos.go |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/gccgo_linux_amd64.go |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/gccgo_c.c |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/fdset.go |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/fcntl.go |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/fcntl_linux_32bit.go |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/fcntl_darwin.go |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/env_unix.go |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/endian_little.go |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/endian_big.go |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/dev_zos.go |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/dev_openbsd.go |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/dev_netbsd.go |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/dev_linux.go |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/dev_freebsd.go |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/dev_dragonfly.go |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/dev_darwin.go |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/dev_aix_ppc64.go |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/dev_aix_ppc.go |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/constants.go |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/bluetooth_linux.go |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/auxv.go |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/auxv_unsupported.go |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/asm_solaris_amd64.s |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/asm_openbsd_mips64.s |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/asm_linux_s390x.s |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/asm_linux_riscv64.s |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/asm_linux_ppc64x.s |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/asm_linux_mipsx.s |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/asm_linux_mips64x.s |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/asm_linux_loong64.s |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/asm_linux_arm64.s |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/asm_linux_arm.s |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/asm_linux_amd64.s |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/asm_linux_386.s |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/asm_bsd_riscv64.s |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/asm_bsd_ppc64.s |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/asm_bsd_arm64.s |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/asm_bsd_arm.s |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/asm_bsd_amd64.s |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/asm_bsd_386.s |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/asm_aix_ppc64.s |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/aliases.go |
Vendored syscall refresh. |
vendor/golang.org/x/sys/unix/.gitignore |
Vendored package metadata refresh. |
vendor/golang.org/x/sys/PATENTS |
Vendored package metadata refresh. |
vendor/golang.org/x/sys/LICENSE |
Vendored package metadata refresh. |
vendor/golang.org/x/net/context/go19.go |
Legacy context vendor migration. |
vendor/golang.org/x/net/context/go17.go |
Legacy context vendor migration. |
vendor/golang.org/x/net/context/context.go |
Legacy context vendor migration. |
vendor/go.etcd.io/etcd/client/v2/util.go |
Updated etcd client support. |
vendor/go.etcd.io/etcd/client/v2/README.md |
Updated etcd client support. |
vendor/go.etcd.io/etcd/client/v2/members.go |
Updated etcd client support. |
vendor/go.etcd.io/etcd/client/v2/keys.go |
Updated etcd client support. |
vendor/go.etcd.io/etcd/client/v2/json.go |
Updated etcd client support. |
vendor/go.etcd.io/etcd/client/v2/doc.go |
Updated etcd client support. |
vendor/go.etcd.io/etcd/client/v2/discover.go |
Updated etcd client support. |
vendor/go.etcd.io/etcd/client/v2/curl.go |
Updated etcd client support. |
vendor/go.etcd.io/etcd/client/v2/cluster_error.go |
Updated etcd client support. |
vendor/go.etcd.io/etcd/client/v2/client.go |
Updated etcd client support. |
vendor/go.etcd.io/etcd/client/v2/cancelreq.go |
Updated etcd client support. |
vendor/go.etcd.io/etcd/client/pkg/v3/types/urls.go |
Updated etcd support package. |
vendor/go.etcd.io/etcd/client/pkg/v3/types/slice.go |
Updated etcd support package. |
vendor/go.etcd.io/etcd/client/pkg/v3/types/id.go |
Updated etcd support package. |
vendor/go.etcd.io/etcd/client/pkg/v3/types/doc.go |
Updated etcd support package. |
vendor/go.etcd.io/etcd/client/pkg/v3/srv/srv.go |
Updated etcd support package. |
vendor/go.etcd.io/etcd/client/pkg/v3/pathutil/path.go |
Updated etcd support package. |
vendor/go.etcd.io/etcd/api/v3/version/version.go |
Updated etcd version metadata. |
vendor/github.com/modern-go/reflect2/unsafe_map.go |
Updated reflection dependency. |
vendor/github.com/modern-go/reflect2/unsafe_link.go |
Reviewed runtime map-iterator compatibility. |
vendor/github.com/modern-go/reflect2/type_map.go |
Updated reflection dependency. |
vendor/github.com/modern-go/reflect2/test.sh |
Updated reflection dependency tests. |
vendor/github.com/modern-go/reflect2/reflect2.go |
Updated reflection dependency. |
vendor/github.com/modern-go/reflect2/Gopkg.toml |
Updated reflection dependency metadata. |
vendor/github.com/modern-go/reflect2/Gopkg.lock |
Updated reflection dependency metadata. |
vendor/github.com/modern-go/reflect2/go_below_19.go |
Updated Go compatibility support. |
vendor/github.com/modern-go/reflect2/go_below_17.go |
Updated Go compatibility support. |
vendor/github.com/modern-go/reflect2/go_below_118.go |
Updated Go compatibility support. |
vendor/github.com/modern-go/reflect2/go_above_19.go |
Updated Go compatibility support. |
vendor/github.com/modern-go/reflect2/go_above_17.go |
Updated Go compatibility support. |
vendor/github.com/modern-go/reflect2/go_above_118.go |
Updated Go compatibility support. |
vendor/github.com/modern-go/reflect2/.travis.yml |
Updated reflection dependency metadata. |
vendor/github.com/json-iterator/go/stream.go |
Reviewed JSON stream flushing behavior. |
vendor/github.com/json-iterator/go/reflect.go |
Updated JSON dependency. |
vendor/github.com/json-iterator/go/reflect_struct_encoder.go |
Updated JSON dependency. |
vendor/github.com/json-iterator/go/reflect_optional.go |
Updated JSON dependency. |
vendor/github.com/json-iterator/go/reflect_marshaler.go |
Updated JSON dependency. |
vendor/github.com/json-iterator/go/reflect_json_raw_message.go |
Updated JSON dependency. |
vendor/github.com/json-iterator/go/reflect_extension.go |
Updated JSON dependency. |
vendor/github.com/json-iterator/go/iter.go |
Updated JSON dependency. |
vendor/github.com/json-iterator/go/iter_skip_sloppy.go |
Updated JSON dependency. |
vendor/github.com/json-iterator/go/iter_int.go |
Updated JSON dependency. |
vendor/github.com/json-iterator/go/iter_float.go |
Updated JSON dependency. |
vendor/github.com/json-iterator/go/iter_array.go |
Updated JSON dependency. |
vendor/github.com/json-iterator/go/go.sum |
Updated JSON dependency metadata. |
vendor/github.com/json-iterator/go/go.mod |
Updated JSON dependency metadata. |
vendor/github.com/json-iterator/go/config.go |
Updated JSON dependency. |
vendor/github.com/json-iterator/go/any_str.go |
Updated JSON dependency. |
vendor/github.com/hashicorp/errwrap/go.mod |
Updated dependency metadata. |
vendor/github.com/godbus/dbus/v5/variant.go |
Updated D-Bus dependency. |
vendor/github.com/godbus/dbus/v5/variant_lexer.go |
Updated D-Bus dependency. |
vendor/github.com/godbus/dbus/v5/transport_zos.go |
Updated D-Bus transport support. |
vendor/github.com/godbus/dbus/v5/transport_unixcred_netbsd.go |
Updated D-Bus credential transport. |
vendor/github.com/godbus/dbus/v5/transport_unixcred_linux.go |
Updated D-Bus credential transport. |
vendor/github.com/godbus/dbus/v5/transport_unixcred_freebsd.go |
Reviewed FreeBSD credential handling. |
vendor/github.com/godbus/dbus/v5/transport_nonce_tcp.go |
Updated D-Bus transport support. |
vendor/github.com/godbus/dbus/v5/transport_generic.go |
Updated D-Bus transport support. |
vendor/github.com/godbus/dbus/v5/server_interfaces.go |
Updated D-Bus dependency. |
vendor/github.com/godbus/dbus/v5/sequence.go |
Updated D-Bus dependency. |
vendor/github.com/godbus/dbus/v5/SECURITY.md |
Updated D-Bus dependency metadata. |
vendor/github.com/godbus/dbus/v5/README.md |
Updated D-Bus dependency metadata. |
vendor/github.com/godbus/dbus/v5/README.markdown |
Updated D-Bus dependency metadata. |
vendor/github.com/godbus/dbus/v5/match.go |
Updated D-Bus dependency. |
vendor/github.com/godbus/dbus/v5/homedir.go |
Updated D-Bus dependency. |
vendor/github.com/godbus/dbus/v5/homedir_static.go |
Updated D-Bus dependency. |
vendor/github.com/godbus/dbus/v5/homedir_dynamic.go |
Updated D-Bus dependency. |
vendor/github.com/godbus/dbus/v5/go.sum |
Updated D-Bus dependency metadata. |
vendor/github.com/godbus/dbus/v5/go.mod |
Updated D-Bus dependency metadata. |
vendor/github.com/godbus/dbus/v5/escape.go |
Updated D-Bus dependency. |
vendor/github.com/godbus/dbus/v5/conn_windows.go |
Updated D-Bus connection support. |
vendor/github.com/godbus/dbus/v5/conn_unix.go |
Updated D-Bus connection support. |
vendor/github.com/godbus/dbus/v5/conn_darwin.go |
Updated D-Bus connection support. |
vendor/github.com/godbus/dbus/v5/call.go |
Updated D-Bus dependency. |
vendor/github.com/godbus/dbus/v5/auth_sha1_windows.go |
Updated D-Bus authentication support. |
vendor/github.com/godbus/dbus/v5/auth_default_windows.go |
Updated D-Bus authentication support. |
vendor/github.com/godbus/dbus/v5/auth_default_other.go |
Updated D-Bus authentication support. |
vendor/github.com/godbus/dbus/v5/.travis.yml |
Updated D-Bus dependency metadata. |
vendor/github.com/godbus/dbus/v5/.golangci.yml |
Updated D-Bus dependency metadata. |
vendor/github.com/godbus/dbus/v5/.cirrus.yml |
Updated D-Bus dependency metadata. |
vendor/github.com/godbus/dbus/transport_unixcred_linux.go |
Updated D-Bus transport support. |
vendor/github.com/godbus/dbus/transport_tcp.go |
Updated D-Bus transport support. |
vendor/github.com/godbus/dbus/transport_generic.go |
Updated D-Bus transport support. |
vendor/github.com/godbus/dbus/MAINTAINERS |
Updated D-Bus dependency metadata. |
vendor/github.com/godbus/dbus/LICENSE |
Updated D-Bus dependency metadata. |
vendor/github.com/godbus/dbus/homedir.go |
Updated D-Bus dependency. |
vendor/github.com/godbus/dbus/homedir_static.go |
Updated D-Bus dependency. |
vendor/github.com/godbus/dbus/homedir_dynamic.go |
Updated D-Bus dependency. |
vendor/github.com/godbus/dbus/doc.go |
Updated D-Bus dependency. |
vendor/github.com/godbus/dbus/CONTRIBUTING.md |
Updated D-Bus dependency metadata. |
vendor/github.com/godbus/dbus/conn_other.go |
Updated D-Bus connection support. |
vendor/github.com/godbus/dbus/conn_darwin.go |
Updated D-Bus connection support. |
vendor/github.com/godbus/dbus/call.go |
Updated D-Bus dependency. |
vendor/github.com/godbus/dbus/auth_external.go |
Updated D-Bus authentication support. |
vendor/github.com/godbus/dbus/.travis.yml |
Updated D-Bus dependency metadata. |
vendor/github.com/coreos/pkg/capnslog/syslog_formatter.go |
Updated logging dependency. |
vendor/github.com/coreos/pkg/capnslog/journald_formatter.go |
Updated logging dependency. |
vendor/github.com/coreos/pkg/capnslog/init.go |
Updated logging dependency. |
vendor/github.com/coreos/go-systemd/v22/NOTICE |
Added go-systemd v22 metadata. |
locksmithctl/reboot.go |
Updated systemd integration. |
locksmithctl/locksmithctl.go |
Updated etcd client integration. |
locksmithctl/daemon.go |
Updated systemd integration. |
lock/etcd.go |
Migrated etcd usage to standard context. |
lock/etcd_test.go |
Updated etcd test usage. |
go.mod |
Updated Go version and dependency requirements. |
Review details
- Files reviewed: 6/479 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
CI passed. |
No, because we still use etcd v2 API. The change to the v3 API is #12. But still, I was rather surprised - going from 0.5.0-alpha.5 (as could be seen in So yeah, |
Picks up flatcar/locksmith#35 and flatcar/locksmith#37. Signed-off-by: Krzesimir Nowak <knowak@microsoft.com>
Picks up flatcar/locksmith#35 and flatcar/locksmith#37. Signed-off-by: Krzesimir Nowak <knowak@microsoft.com>
Picks up flatcar/locksmith#35 and flatcar/locksmith#37. Signed-off-by: Krzesimir Nowak <knowak@microsoft.com>
Picks up flatcar/locksmith#35 and flatcar/locksmith#37. Signed-off-by: Krzesimir Nowak <knowak@microsoft.com>
CI: https://jenkins.flatcar.org/job/container/job/packages_all_arches/700/cldsv/