Wrap conditions after-first - #7
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
test.sh has been failing since cba5551 ("Merge remote-tracking branch 'square/master'"), which swapped the clang-format binary from 19.1.4 to the 21.0.0git 60b43ef build, rewrote a number of .clang-format settings, and added new custom pre/post processors -- but left the expected-output fixtures alone. Every difference is explained by an intentional change in that commit: SortIncludes false -> true, IncludeBlocks: Merge reordered imports BraceWrapping.AfterObjCDeclaration true -> false dropped blank lines ObjCSpaceAfterProperty: true removed @Property (x) -> @Property(x) SpacesInContainerLiterals true -> false @[ x ] -> @[x], @"k" : v -> @"k": v AllowShortFunctionsOnASingleLine All -> None inline ctor bodies split AlignTrailingComments true -> false macro continuation alignment new custom/RemoveVoidBlockDeclaration.py ^(void) { -> ^{ The config is the correct side here, not the fixtures: Fantastical's committed Objective-C already uses the new container-literal style by a wide margin (@[x] 1932 occurrences vs @[ x ] 2). Regenerated FormattedExample.m and UnicodeFormattedExample.m from format-objc-file-dry-run.sh. The other four cases already passed. Full suite, including the idempotence and in-place checks, now passes. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
ksuther
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also fixed existing test failures on the objc side.