Conversation
Author
|
I also
|
AlecThomson
requested changes
Aug 25, 2026
| if pix_sigma < 1: | ||
| # linspace can only take integer inputs, and if sigma is too small then this array comes | ||
| # out as length zero. | ||
| msg = f"{scale=} is too small and an appropriately sized kernel can not be formed. Consider removing it. " |
Contributor
There was a problem hiding this comment.
"Consider removing it."
What does "it" mean here? Can we make this message more explicit on what to change?
Comment on lines
+28
to
+40
| # - repo: https://github.com/pre-commit/pygrep-hooks | ||
| # rev: "v1.10.0" | ||
| # hooks: | ||
| # - id: rst-backticks | ||
| # - id: rst-directive-colons | ||
| # - id: rst-inline-touching-normal | ||
|
|
||
| - repo: https://github.com/rbubley/mirrors-prettier | ||
| rev: "v3.8.3" | ||
| hooks: | ||
| - id: prettier | ||
| types_or: [yaml, markdown, html, css, scss, javascript, json] | ||
| args: [--prose-wrap=always] | ||
| # - repo: https://github.com/pre-commit/mirrors-prettier | ||
| # rev: "v4.0.0-alpha.8" | ||
| # hooks: | ||
| # - id: prettier | ||
| # types_or: [yaml, markdown, html, css, scss, javascript, json] | ||
| # args: [--prose-wrap=always] |
Contributor
There was a problem hiding this comment.
Why are these removed?
| hooks: | ||
| - id: mypy | ||
| files: eye_patch|tests | ||
| files: flint|tests |
Contributor
There was a problem hiding this comment.
Suggested change
| files: flint|tests | |
| files: eye_patch|tests |
Bad copy-paste
Contributor
There was a problem hiding this comment.
Why were changes needed here?
Contributor
|
@tjgalvin - can we revert the pre-commit changes? I'd rather address more explicitly, I think its a numpy / mypy / python version clash. We're also running to an issue I've hit bunch lately with my CD.yml The fix is to bump to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Beth, of GASKAP-OH fame, pointed out two issues.
The first was that in some circumstances a
boolmask array is passed forfits.writeto, which subsequently raises an error. I don't know how long this one has been around for - I feel like I should have seen it long ago. We may have overlooked something when removing the logic from flint to eye-patch. An easy fix anyway.The next was around how the gaussian kernels are constructed in the beam erosion stage. It is possible for the scale to be so small that a gaussian kernel can not be created. The sigma width is so small that it is well within a single pixel, which then breaks the coordinate system we evaluate the kernel over. In this case I have added a more informative error as there is really nothing I think we ought to be doing here. This error would only be tripped for a very small scale, like
--beam-shape-erode-scales 1, otherwise no change.