Repository navigation
fix(cli): validate scan roots and warn on empty scans - #12
Merged
Merged
Conversation
Reject missing or non-directory scan roots with exit status 2 and a diagnostic that names the supplied path. Warn on stderr when a valid scan matches zero files, while still writing SARIF and exiting successfully.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
Signed-off-by: odykyi <24225497+odykyi@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11.
Reject missing and non-directory scan roots with exit code 2 and a diagnostic naming the path. Warn on stderr when a valid scan matches no files, while still writing an empty SARIF report and exiting successfully. Document both outcomes in the README.
Regression tests cover an invalid scan root and an empty scan. All 18 tests passed in network-disabled Docker containers on Python 3.9 and 3.12.