Skip to content

Reset failed check run back to in progress if all failed jobs are re-runned - #5117

Merged
auto-submit[bot] merged 3 commits into
flutter:mainfrom
ievdokdm:189943-rerequest
Jul 31, 2026
Merged

Reset failed check run back to in progress if all failed jobs are re-runned#5117
auto-submit[bot] merged 3 commits into
flutter:mainfrom
ievdokdm:189943-rerequest

Conversation

@ievdokdm

Copy link
Copy Markdown
Contributor

@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Jul 29, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the LUCI build service to support re-requesting check runs when re-running failed checks under the unified check run flow, updating the github package dependency to version 9.26.0 and adding corresponding tests and mocks. A review comment correctly points out that the stage != null condition is unnecessarily required for initial runs, which could prevent updating the check run status to in-progress when stage is null, and suggests restricting this check to re-runs.

Comment thread app_dart/lib/src/service/luci_build_service.dart Outdated
Comment thread app_dart/lib/src/service/luci_build_service.dart
@ievdokdm ievdokdm added the autosubmit Merge PR when tree becomes green via auto submit App. label Jul 31, 2026
@auto-submit
auto-submit Bot merged commit 42ae12e into flutter:main Jul 31, 2026
26 checks passed
auto-submit Bot pushed a commit that referenced this pull request Aug 3, 2026
logging for debugging behavior of #5117
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App. CICD Run CI/CD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

autosubmit removed due to "Dashboard Checks" failing, even though tests are in progress

2 participants