Repository navigation
Conversation
energy-models#980's `in:` on top of energy-models#1015's maps. A parameter or a variable lists under `in:` the relations whose rows it exists on; a tool refuses a data row of a parameter outside them. A relation's bare name in the `where:` of a parameter or a variable is refused, with `in:` as the rewrite. Co-Authored-By: Fabian Hofmann <fab.hof@gmx.de> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018B3nA1xxh6NMJN6mrYY34Q
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018B3nA1xxh6NMJN6mrYY34Q
An entry over a dimension twice, as TIMES' IRE_FLO: the alias's docs example lists the links under in:, and a test states IRE_FLO in this spelling. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018B3nA1xxh6NMJN6mrYY34Q
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018B3nA1xxh6NMJN6mrYY34Q
The TIMES examples in this PR's spelling: act lists prc_ts and rtp_vintyr under in:, and ire_flo, trade_cost and export list top_ire, in place of the where: that A refuses. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018B3nA1xxh6NMJN6mrYY34Q
sparse.yaml in this PR's spelling: efficiency, flow and output list their relation under in:, so a stray data row is refused. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018B3nA1xxh6NMJN6mrYY34Q
…pare/confine # Conflicts: # docs/examples/times/trade.md # examples/times/trade.yaml
`sum(x, over=connection)` was refused with the relation's dims as the rewrite. The load now writes that rewrite: a relation in `over=` stands for the columns of its key, and for none of its maps. `along=` and `dims:` keep refusing a relation. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018B3nA1Y7i5TWDbh9SKx86i
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018B3nA1Y7i5TWDbh9SKx86i
This was referenced Nov 17, 2026
The base renames `maps:` to `mappings:`. The lines this branch adds say the same: `mappings:`, `MappingSpec`, `Spec.mappings`, `subject[mapping]` and "mapping" in messages, docstrings, tests and the reference. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018B3nA1Y7i5TWDbh9SKx86i
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
The following content was generated by AI.
What this changes
Confine (energy-models#1016) on the alias PR, plus one thing:
sum(…, over=<relation>)sums over the relation's key instead of refusing.examples/sparse.yaml, before (feat/dimension-alias):After (this PR, loads with
to_spec):TIMES (
examples/times/):(before: the same
dims:withwhere: rtp_vintyr AND prc_tsandwhere: top_ire)Why
Draft, for comparison, not for merge. The other design: #8 (Multi-dims).
dims:and confines itself within:.over=a relation stands for the relation's key columns, not its mappings. Besideby=the same relation, the key stays as column names.along=anddims:still refuse a relation, with its dimensions as the rewrite.in:.Method, gate output, alternatives
Method
mainwas not updated: the push of upstreammain(fast-forward, 37 commits ahead) was refused by this session's permission check. Upstreamfeat/dimension-aliasis on the fork as the base: first96c1002, then fast-forwarded (no force) to06e52956.feat/maps-in(c8ee83d) + merge offeat/dimension-aliasat96c1002. Conflicts inexamples/times/trade.yamland its gallery page: took upstream'sprocesscolumn, keptin: [top_ire], rewrote the prose, regenerated the page.7bdb46c7: mergedfeat/dimension-aliasat06e52956(upstream'smaps:→mappings:). 12 conflicts in 11 files, each the rename against a line this branch changed. Each kept this branch's meaning. The lines this branch adds now saymappings:,MappingSpec,Spec.mappings,_mapping_targets,subject[mapping]and "mapping". Generated files regenerated. Gate after the merge: lint pass; test 4304 passed, 1 skipped; docs-build no issues; render-tex 62 specs; compile-tex blocked as below._expression_resolver._relations_expandedreplaces a relation inover=with its key.over=connection, by=connection[bus]namedbustwice. Reproduced intest_a_sum_over_a_relation_with_a_map_sums_over_its_key_alone(fails on the first draft, passes now).overcase lefttest_a_relation_named_where_a_dimension_belongs_is_refused; its coverage moved totest_a_sum_over_a_relation_is_a_sum_over_its_dims(plain, list, besideby=) and…_names_that_dim_twice.Gate (
pixi0.84.2, thedefaultenvironment, at7bdb46c7)pixi run lint: all hooks pass.pixi run test: 4304 passed, 1 skipped.pixi run docs-build: no issues.pixi run render-tex: 62 specs rendered.pixi run compile-tex: not run to completion. tectonic cannot download its bundle fromrelay.fullyjustified.nethere.Not done
in:on constraints (kept as feat(language)!: relation rows may index an entry energy-models/mathspec#1016).map(…_with_a_map_…); only their bodies were renamed.🤖 Generated with Claude Code
https://claude.ai/code/session_018B3nA1Y7i5TWDbh9SKx86i