Repository navigation
Conversation
Where a per-entity offset= is missing: absent, the shift is absent at that coordinate whatever the edge. Both lanes built the row instead: the relational lane with no term, the linopy lane with the offset read as 0. Fixes #2093 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018B3nA1SdobWD7mq3V7guXh
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018B3nA1SdobWD7mq3V7guXh
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 40 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Merging this PR will improve performance by 36.94%1 warning
Performance Changes
Tip Curious why performance improved? Comment Comparing Footnotes
|
Note
The following content was generated by AI.
Where a
missing: absentoffset has no row,shiftis absent there underedge=0andedge='wrap', so the row is not built. Both lanes.Method, gates, mutation table
shifts.py). The path for an operand with a presence was already right; the masked-operand cases pin it.missing: absentoffset stays NaN, and the gather is emptied there,by=included.test_an_absent_offset_leaves_the_shift_absent, edge0/'wrap'× bare/masked operand, throughdifferential; row count and objective pinned (3 rows/30, 2 rows/40). Watched xfail strictly on 4a3dc84, then the marker came off.uvrather than pixi (not installed):uv run pytest5884 passed, 574 skipped, 4 xfailed;ruff check .clean;ruff format --check .clean;pyrefly check0 errors.docs-build,docs-test,test-floors,test-via-pyarrow,test-pyodide, benches. The extra presence join on a named-offset shift is not measured.within=) with an absent offset gives the same answer on both lanes (30, 3 rows).missing: refused, the default, refuses the missing row at load, so it has no case.missing: neutralhas no stated value for an offset. The oracle reads it as 0, and the relational lane now reads it as absent, so the lanes disagree there.shifts.py:200-201,tools.mutate).where(offset.notnull())(by hand)[fill-bare-operand]_amount, NaN as 0 (by hand)[fill-bare-operand]Fixes #2093
Generated by Claude Code