Repository navigation
Conversation
… missing rows Strict xfail on #2064. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018B3nA1SdobWD7mq3V7guXh
A cases: region worth the literal 0 builds no term, so a divisor left with one term under a region read the coordinates that region claims as null, and was refused as missing rows of a parameter that has every row. A lone divisor term under a region is now added up like several, reading zero outside its region, and refused as a zero divisor. Fixes #2064. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018B3nA1SdobWD7mq3V7guXh
Strict xfail: the relational lane drops or zeroes the row instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018B3nA1SdobWD7mq3V7guXh
A lone term under a cases: region is added up for a power's operand too, so the coordinates a region worth the literal 0 claims read 0 rather than null. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018B3nA1SdobWD7mq3V7guXh
… as 0 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018B3nA1SdobWD7mq3V7guXh
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 23 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Merging this PR will not alter performance
Comparing Footnotes
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
The following content was generated by AI.
A divisor that a
cases:region makes0is refused as a zero divisor. The refusal no longer asks for missing rows ofd, which has every row. An exponent that a case makes0now raises to1.Cause, the second bug, gates, mutation table
1 - 1in a case no longer shows the bug: it already reads "not finite where the model divides by 'd'". The literal0still shows it.0builds no term (casesincompiler.py). When one term is left under a region,_added_upreturned it as it was, so the coordinates the zero region claims read null. A null divisor is refused as a missing row.summed_onto), so outside its region it reads0. One condition in_added_up.2 ** eread null whereeis that zero. That boundsx <= 2 ** eby0there, and drops the row ofx * 2 ** e <= 10there. A silent wrong answer: relational 4.0 vs linopy 5.0, and 102.5 vs 12.5. My first fix kept powers on the old path (absent != 'spreads' or …). The suite survived deleting that clause, and a probe showed the clause only kept this bug. So the clause is gone, and the power has its own strict-xfail-first test.d, the parameter the divisor reads, as forx / (d - 2). Note: every divisor message names parameters, and naming the expression would change both lanes' messages for every divisor.tests/test_arithmetic_laws.py, beside the zero-divisor cases:a-case-worth-zerointest_a_zero_divisor_under_a_variable_is_refused_on_both_lanes, which also asserts thatmissing rowsis absent from the messagea-case-worth-zerointest_a_zero_divisor_on_a_constant_side_is_refused_on_both_lanestest_an_exponent_a_case_makes_zero_raises_to_one, parametrized for the constant side and beside a variablepixi run check:uv run pytest: 5884 passed, 574 skipped, 4 xfaileduv run ruff check .: all checks passeduv run ruff format --check .: 437 files already formatteduv run pyrefly check: 0 errorsdocs-build,docs-test,test-via-pyarrow,test-floors,test-pyodide.result.evaluate('x / e')) of the same zero case is still refused with the missing-rows wording,reported_divisor_message. A read adds up withholesemantics, and the code relies on that intest_a_read_through_a_cased_divisor_is_refused_where_the_case_that_applies_has_no_row.Mutation table, taken by hand because
tools/mutate.pydeletes lines and cannot drop half a condition. Clean tree,git checkout --restore,__pycache__dropped on both sides, full suite each time:len(terms) == 1 and terms[0].region is None→len(terms) == 1absent != 'spreads' ordroppedFixes #2064
Generated by Claude Code