Skip to content

Restore marketplace licensing and add plugin smoke tests - #114

Open
Dawsson wants to merge 8 commits into
masterfrom
dawson/fix-marketplace-update-guard
Open

Restore marketplace licensing and add plugin smoke tests#114
Dawsson wants to merge 8 commits into
masterfrom
dawson/fix-marketplace-update-guard

Conversation

@Dawsson

@Dawsson Dawsson commented Aug 16, 2026

Copy link
Copy Markdown
Member

Summary

  • restore MCLicense marketplace key bootstrap for BuiltByBit and Polymart downloads
  • add MockBukkit lifecycle and command coverage
  • add a disposable real-Paper smoke test that installs ViaVersion through the public API
  • run unit and Paper smoke tests on pull requests with read-only permissions and pinned actions

Verification

  • ./gradlew test
  • ./gradlew :plugin:paperSmoke

Actions security

  • uses pull_request, not pull_request_target
  • grants only read-only repository contents permission
  • does not expose secrets
  • disables checkout credential persistence
  • pins actions to commit SHAs
  • repository now requires approval for workflow runs from all external contributors

@Dawsson
Dawsson force-pushed the dawson/fix-marketplace-update-guard branch from 4e0bc27 to 7252726 Compare August 16, 2026 03:35

@Zoriot Zoriot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to fix the active regression which was with the code currently at master.
Only tested in game, have not reviewed the code itself.

One issue which could be fixed here is that on a 1.21.11 Server it still suggests to update mclo.gs to 3.3.3 which is only combatible with mc 26.2 & 26.1 - https://modrinth.com/plugin/mclogs/version/3.3.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants