Skip to content

feat(byv): add the medumba dataset#40

Merged
pythonbrad merged 6 commits into
masterfrom
patch_byv
Jul 23, 2026
Merged

feat(byv): add the medumba dataset#40
pythonbrad merged 6 commits into
masterfrom
patch_byv

Conversation

@pythonbrad

@pythonbrad pythonbrad commented Jul 23, 2026

Copy link
Copy Markdown
Member

Related issues

Changes

  • added the medumba dataset

Summary by CodeRabbit

  • New Features
    • Added Medumba configuration with runtime settings and references to external data sources.
    • Added a Vietnamese translation dictionary with canonical mappings and alias variants.
    • Added new Vietnamese input method configurations for Telex and VNI, including detailed letter-to-diacritic conversion rules.
  • Documentation
    • Updated the README to include the Vietnam input method section and configuration overview.

@pythonbrad pythonbrad self-assigned this Jul 23, 2026
@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@pythonbrad, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 36 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: ee72e6f7-7c6d-44bf-924e-b1663a92a13b

📥 Commits

Reviewing files that changed from the base of the PR and between 7115bfe and ace4f1b.

📒 Files selected for processing (1)
  • README.md
📝 Walkthrough

Walkthrough

Adds Vietnamese input method metadata, VNI and Telex mappings, Medumba dictionary data, runtime wiring, and README registration.

Changes

Vietnamese input method package

Layer / File(s) Summary
Vietnamese input method configuration
vie/vie.toml, vni/vni.toml
Defines Vietnamese input method metadata, runtime behavior, and references to the VNI and Telex configurations.
VNI and Telex character mappings
vni/vni.toml, telex/telex.toml
Adds Vietnamese vowel and consonant mappings, diacritic combinations, and alternate VNI or Telex sequences.
Medumba dictionary and package configuration
byv/dictionary.toml, byv/byv.toml, README.md
Adds dictionary metadata, canonical translations with aliases, Medumba runtime paths, and README registration for Vietnam.

Estimated code review effort: 4 (Complex) | ~45 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: adding the Medumba dataset under byv.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch patch_byv

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@byv/dictionary.toml`:
- Line 673: Update the dictionary entry key to use “neu1” without the combining
grave, and change the value’s “nə̀̀” to the single-grave form “nə̀”; preserve
the rest of the entry unchanged.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: d3af40b4-eee4-499f-8b9d-aaa4ba2d40df

📥 Commits

Reviewing files that changed from the base of the PR and between 7584bc3 and 8513ed4.

📒 Files selected for processing (2)
  • byv/byv.toml
  • byv/dictionary.toml

Comment thread byv/dictionary.toml Outdated
pythonbrad and others added 4 commits July 23, 2026 17:05
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@README.md`:
- Around line 41-43: Update the README language entry to register Medumba using
the byv identifier, replacing the Vietnam/vie label and link while preserving
the existing configuration description.

In `@telex/telex.toml`:
- Around line 72-227: Add the missing fully capitalized key variants across the
e, o, u, y, and i series in telex.toml: define ES/EF/ER/EX/EJ/EE, corresponding
O/U/Y/I variants, and all accented uppercase values matching the existing three
capitalization forms. Apply the same four-combination pattern already used by
the a-series, including compound tone keys where applicable.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: d47fe2fc-5ebb-4a79-b4f5-124b38fb8fee

📥 Commits

Reviewing files that changed from the base of the PR and between 8513ed4 and 2bb27af.

📒 Files selected for processing (5)
  • README.md
  • byv/dictionary.toml
  • telex/telex.toml
  • vie/vie.toml
  • vni/vni.toml
🚧 Files skipped from review as they are similar to previous changes (1)
  • byv/dictionary.toml

Comment thread README.md
Comment thread telex/telex.toml
@pythonbrad
pythonbrad merged commit 8d60acb into master Jul 23, 2026
2 checks passed
@pythonbrad
pythonbrad deleted the patch_byv branch July 23, 2026 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant