feat(byv): add the medumba dataset#40
Conversation
|
Warning Review limit reached
Next review available in: 36 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. 📝 WalkthroughWalkthroughAdds Vietnamese input method metadata, VNI and Telex mappings, Medumba dictionary data, runtime wiring, and README registration. ChangesVietnamese input method package
Estimated code review effort: 4 (Complex) | ~45 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@byv/dictionary.toml`:
- Line 673: Update the dictionary entry key to use “neu1” without the combining
grave, and change the value’s “nə̀̀” to the single-grave form “nə̀”; preserve
the rest of the entry unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: d3af40b4-eee4-499f-8b9d-aaa4ba2d40df
📒 Files selected for processing (2)
byv/byv.tomlbyv/dictionary.toml
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@README.md`:
- Around line 41-43: Update the README language entry to register Medumba using
the byv identifier, replacing the Vietnam/vie label and link while preserving
the existing configuration description.
In `@telex/telex.toml`:
- Around line 72-227: Add the missing fully capitalized key variants across the
e, o, u, y, and i series in telex.toml: define ES/EF/ER/EX/EJ/EE, corresponding
O/U/Y/I variants, and all accented uppercase values matching the existing three
capitalization forms. Apply the same four-combination pattern already used by
the a-series, including compound tone keys where applicable.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: d47fe2fc-5ebb-4a79-b4f5-124b38fb8fee
📒 Files selected for processing (5)
README.mdbyv/dictionary.tomltelex/telex.tomlvie/vie.tomlvni/vni.toml
🚧 Files skipped from review as they are similar to previous changes (1)
- byv/dictionary.toml
Related issues
Changes
Summary by CodeRabbit